Repository navigation
fix: use shared Avatar in comparison table - #264
Open
sulimanshams wants to merge 1 commit into
Open
sulimanshams wants to merge 1 commit into
sulimanshams wants to merge 1 commit into
Conversation
|
@sulimanshams is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
requested changes
Oct 23, 2026
O2sa
left a comment
O2sa
left a comment
Owner
There was a problem hiding this comment.
One small cleanup before merging: please remove the unused Image import from next/image and the commented-out duplicate import. Also, please confirm that the shared fallback works for missing or whitespace-only avatar URLs in the comparison table.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the direct next/image usage in the comparison table with the shared Avatar component.
Preserve the 40px avatar size and existing accessibility text.
Reuse the shared component's fallback behavior when an avatar URL is missing.
Testing:
pnpm lint
pnpm test -- --run
Related issue: #240