[18.0] [MIG] ai_oca_mcp by angelmoya · Pull Request #76 · OCA/ai

angelmoya · 2026-06-05T12:09:10Z

Migration to 18.0

No major changes.

Depends on #69

Currently translated at 100.0% (43 of 43 strings) Translation: ai-16.0/ai-16.0-ai_oca_mcp Translate-URL: https://translation.odoo-community.org/projects/ai-16-0/ai-16-0-ai_oca_mcp/it/

oliverg09 · 2026-06-11T08:49:21Z

Hello,

I've been reviewing this PR and noticed some behavior that might be worth looking into when an MCP key expires. In that case, the exception AttributeError: ‘function’ object has no attribute ‘clear_cache’ is raised.

It seems to be related to line 31 of the file models/mcp_server_key.py.

Since I’m not yet a member of the organization, I can’t contribute directly. To avoid holding things up, I’d really appreciate it if you could take a look at it when you have a moment. Of course, if you’d rather wait, that’s no problem: as soon as I have permissions, I’ll be happy to push the change and help out.

Thank you very much for your time.

petrus-v

The authentication mechanisms sees pretty coupled to the mcp endpoint that I've the feeling it will be hard to overload it to implement an other one

petrus-v · 2026-06-29T08:04:48Z

+    def _hash_key(self, key):
+        return sha256(key.encode()).hexdigest()
+
+    @tools.ormcache("key", "security_key")


should we invalidate cache when expiration_date change?

petrus-v · 2026-06-29T08:05:58Z

+            .sudo()
+            ._get_mcp_server_by_key(key, security_key)
+        )
+        if expiration_date and expiration_date < fields.Datetime.now():


I don't see the interest of this condition because _get_mcp_server_by_key already filter expired server key. Do I miss a case? or is it because the cache is not invalidated when expiration_date changed?

petrus-v · 2026-06-29T08:21:58Z

+
+class McpController(http.Controller):
+    @http.route(
+        "/mcp/<string:key>", type="http", auth="none", methods=["POST"], csrf=False


I'm would suggested to create a dedicated auth="ai_mcp" and de-coupled authentication and business logic even it generate an extra request.

petrus-v · 2026-06-29T08:36:13Z

+            ._get_mcp_server_by_key(key, security_key)
+        )
+        if expiration_date and expiration_date < fields.Datetime.now():
+            request.env["mcp.server.key"].sudo().browse(server_id).expire_key()


I think will never been called because the filter, I would separate the way how the expire state is changed, using ir.cron ?

probably called if the key come from cache

petrus-v · 2026-06-29T08:38:53Z

+                    "error": {"code": -32000, "message": "Connection failed"},
+                }
+            )
+        server = request.env["mcp.server.key"].sudo().browse(server_id)


could you rename this variable to something like mcp_server_key as you have mcp.server it's a bit confusing

Suggested change

server = request.env["mcp.server.key"].sudo().browse(server_id)

mcp_server_key = request.env["mcp.server.key"].sudo().browse(server_id)

done in this commit: 0ef5ad3 (in migratoin PR to v17)

petrus-v · 2026-06-29T08:58:23Z

+                    "id": payload.get("id"),
+                    "result": {
+                        "protocolVersion": "2025-03-26",
+                        "capabilities": {"tools": {"listChanged": True}},


I haven't seen any call to notified clients, do I miss something or mis understand th protocal, As far I understand this listChanded capabilities indicate the client the it will be notified when tools list result would changed

Suggested change

"capabilities": {"tools": {"listChanged": True}},

"capabilities": {"tools": {}},

Done by d621868 (in migratoin PR to v17)

petrus-v · 2026-06-29T09:00:45Z

+    name = fields.Char()
+    description = fields.Text()
+    active = fields.Boolean(default=True)
+    key = fields.Char(


non locking point: Idea of improvement, add api.constraints to ensure it's a valid url path

petrus-v · 2026-06-29T09:14:34Z

+                "result": {
+                    "structuredContent": result,
+                    "content": [{"type": "text", "text": json.dumps(result)}],
+                },


it seems resultType is required in result

Suggested change

"result": {

"structuredContent": result,

"content": [{"type": "text", "text": json.dumps(result)}],

},

"result": {

"resultType": "complete",

"structuredContent": result,

"content": [{"type": "text", "text": json.dumps(result)}],

},

you can ignore this message, I've linked the draft version of the protocol

petrus-v · 2026-06-29T14:09:31Z

just realize this is a migration PR so I guess those comment are valid in version 16.0 too.

I'm on the way to migrate this module from v16.0 to v17.0 I'll probably create the PR on top of it to make easier back/forward ports

petrus-v · 2026-06-29T14:51:16Z

+    hashed_key = fields.Char(copy=False)
+    state = fields.Selection(
+        [("active", "Active"), ("expired", "Expired")], default="active"
+    )


Using field selection for those 2 states I'm wondering why we are not rely on Odoo active bool feature ? that we could use those state later for an other purpose different than active or archvied

petrus-v · 2026-06-29T15:34:32Z

+    key = fields.Char(
+        required=True,
+        copy=False,
+        default=lambda self: uuid4(),
+        groups="base.group_system",
+    )


the name of this field is a bit confusing, mainly because of mcp.server.key model... I would suggested to named it slug / slug path / server path

etobella and others added 6 commits June 5, 2026 14:01

[ADD] ai_oca_mcp

b1a69d2

[UPD] Update ai_oca_mcp.pot

4590960

[BOT] post-merge updates

f8043ca

Added translation using Weblate (Italian)

96ffc2f

Translated using Weblate (Italian)

0c1dea4

Currently translated at 100.0% (43 of 43 strings) Translation: ai-16.0/ai-16.0-ai_oca_mcp Translate-URL: https://translation.odoo-community.org/projects/ai-16-0/ai-16-0-ai_oca_mcp/it/

[IMP] ai_oca_mcp: pre-commit auto fixes

600427b

OCA-git-bot added mod:ai_oca_mcp Module ai_oca_mcp series:18.0 labels Jun 5, 2026

[MIG] ai_oca_mcp: Migration to 18.0

5ac6fe0

angelmoya force-pushed the 18.0-mig-ai_oca_mcp branch from e54dedd to 5ac6fe0 Compare June 5, 2026 12:13

angelmoya mentioned this pull request Jun 23, 2026

Native ROADMAP #73

Open

petrus-v reviewed Jun 29, 2026

View reviewed changes

	server = request.env["mcp.server.key"].sudo().browse(server_id)
	mcp_server_key = request.env["mcp.server.key"].sudo().browse(server_id)

	"capabilities": {"tools": {"listChanged": True}},
	"capabilities": {"tools": {}},

Uh oh!

Uh oh!

Conversation

angelmoya commented Jun 5, 2026

Uh oh!

oliverg09 commented Jun 11, 2026

Uh oh!

petrus-v left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petrus-v Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petrus-v commented Jun 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petrus-v Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petrus-v Jun 29, 2026 •

edited

Loading

petrus-v Jun 29, 2026 •

edited

Loading