[18.0][IMP] dms: Clean up attachments after creation of file

[tarteo]

Fixes: #468

[pedrobaeza]

Why an attachment is created in first place?

[tarteo]

@pedrobaeza It reuses /web/binary/upload_attachment that creates the attachment, but functionally I don't think there's a reason.

[pedrobaeza]

Then isn't better to do the upload other way for not generating that garbage?

[tarteo]

@pedrobaeza I don't know if it's used for something, I assume there is / was a reason to use the endpoint.

[pedrobaeza]

I don't think so apart from reducing the code in this part, but having that side effects, this is to be questioned. @victoralmau can you confirm?

[victoralmau]

I don't think so apart from reducing the code in this part, but having that side effects, this is to be questioned. @victoralmau can you confirm?

I see that this was added in v16 (#262), since there is already a method in the web version with similar functionality (https:// github.com/odoo/odoo/blob/af32885ec5f07d492f3b8e8fff1785996a739f72/addons/web/controllers/binary.py#L217), I infer that the intention was to reduce the code a bit and use it; therefore, the change added in this PR is necessary.

[pedrobaeza]

Yes, but as said, with this high side effect, I would switch again to have the complete upload handle here in this module instead of using the other, but generating the garbage. Maybe a part of the other code can be used without generating the attachment.