[19.0][MIG] website_sale_require_legal: Migration to version 19.0#1260
Conversation
…cope This is what the module does now: - Add the posibility to configure legal terms acceptance requirement before saving a new partner. - Log that acceptance as a note in the partner. - Extend upstream's legal requirement before payment and log that acceptance as a note in the sale order. @Tecnativa TT25963
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_require_legal/es/
…page TT41842 The dependency on website_legal_page has been removed because it has been merged into account
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_legal/es/
…e_vat_required module TT44388
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_require_legal/it/
Currently translated at 0.0% (0 of 3 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_require_legal/de/
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_require_legal/es/
Currently translated at 0.0% (0 of 3 strings) Translation: e-commerce-18.0/e-commerce-18.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_require_legal/fi/
OCA-git-bot
added
series:19.0
mod:website_sale_require_legal
pilarvargas-tecnativa
force-pushed
the
19.0-mig-website_sale_require_legal
branch
2 times, most recently
from
95331dd to
f8dcd1c
Compare
|
The error is caused by the website_sale_charge_payment_fee module, this needs to be checked |
pilarvargas-tecnativa
force-pushed
the
19.0-mig-website_sale_require_legal
branch
from
f8dcd1c to
08c4dea
Compare
pilarvargas-tecnativa
force-pushed
the
19.0-mig-website_sale_require_legal
branch
from
08c4dea to
b799f95
Compare
|
/ocabot migration website_sale_require_legal The README is still not clarifying why this module is needed over the standard legal terms. |
Isn’t the detailed explanation provided in context at the time clear enough? Should it be added elsewhere in the README? |
|
That explanation is not reflected in the module itself, and now I don't remember it. |
pilarvargas-tecnativa
force-pushed
the
19.0-mig-website_sale_require_legal
branch
from
b799f95 to
5c6a96b
Compare
I've added a short sentence to the description to make that distinction explicit. I thought the context section already conveyed that idea, but I agree it's useful to mention it earlier as well. Do you think it's clear enough now? |
|
Thanks, now I remember, although I think the standard is enough for most of the cases. |
I agree, the standard option is enough for most cases. However, this functionality is still requested in real-world scenarios: requiring the acceptance of the legal terms when creating or editing an address, together with keeping metadata about the acceptance for audit or legal purposes. |
eduezerouali-tecnativa
left a comment
eduezerouali-tecnativa
left a comment
There was a problem hiding this comment.
Code LGTM + tested on runboat
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4d197a3. Thanks a lot for contributing to OCA. ❤️ |
18 participants
@Tecnativa TT63427
@eduezerouali-tecnativa @juancarlosonate-tecnativa please review