Skip to content

[18.0][MIG] base dns infrastructure: Migration to 18.0#23

Merged
OCA-git-bot merged 12 commits into
OCA:18.0from
flotho:18.0-mig-base_dns_infrastructure
Dec 18, 2025
Merged

[18.0][MIG] base dns infrastructure: Migration to 18.0#23
OCA-git-bot merged 12 commits into
OCA:18.0from
flotho:18.0-mig-base_dns_infrastructure

Conversation

@flotho
Copy link
Copy Markdown
Member

@flotho flotho commented Nov 20, 2025

No description provided.

@flotho flotho mentioned this pull request Nov 20, 2025
Open
1 task
@flotho flotho force-pushed the 18.0-mig-base_dns_infrastructure branch from dfa3a6b to f222317 Compare November 20, 2025 21:51
flotho and others added 9 commits November 20, 2025 22:59
@flotho
[16.0][ADD]base_dns_infrastructure
9100d15 
[LINT]Run the precommit

[16.0][ADD]base_dns_infrastructure

[FIX]base_dns_infrastructure: bad message

[IMP]base_dns_infrastructure: Demo data

[IMP]base_dns_infrastructure: Demo data + Security
@flotho
[IMP]base_dns_infrastructure: Pylint
d2b343a 
[IMP]base_dns_infrastructure: Pylint
@flotho
[UPD] Update base_dns_infrastructure.pot
e1378f3
@OCA-git-bot @flotho
[BOT] post-merge updates
cc31da8
@mymage @flotho
Added translation using Weblate (Italian)
6bfbe22
@mymage @flotho
Translated using Weblate (Italian)
ff2bbee 
Currently translated at 100.0% (92 of 92 strings)

Translation: infrastructure-16.0/infrastructure-16.0-base_dns_infrastructure
Translate-URL: https://translation.odoo-community.org/projects/infrastructure-16-0/infrastructure-16-0-base_dns_infrastructure/it/
@mymage @flotho
Translated using Weblate (Italian)
bf9e2f2 
Currently translated at 100.0% (92 of 92 strings)

Translation: infrastructure-16.0/infrastructure-16.0-base_dns_infrastructure
Translate-URL: https://translation.odoo-community.org/projects/infrastructure-16-0/infrastructure-16-0-base_dns_infrastructure/it/
@flotho
[IMP] base_dns_infrastructure: pre-commit execution
2e65200
@flotho
[MIG] base_dns_infrastructure: Migration to 18.0
985a820
@flotho flotho force-pushed the 18.0-mig-base_dns_infrastructure branch from f222317 to 985a820 Compare November 20, 2025 22:00
@flotho flotho changed the title WIP 18.0 mig base dns infrastructure [18.0][MIG] base dns infrastructure: Migration to 18.0 Nov 20, 2025
@flotho flotho mentioned this pull request Nov 20, 2025
Merged
@flotho flotho marked this pull request as ready for review November 20, 2025 22:37
@flotho
Copy link
Copy Markdown
Member Author

flotho commented Nov 20, 2025

ping @DorianMAG @JulienMartinez

@flotho flotho force-pushed the 18.0-mig-base_dns_infrastructure branch from b4c5699 to 7c687d1 Compare November 20, 2025 22:43
@flotho
[IMP] base_dns_infrastructure: view formatting
fcc27a9 
[LINT] base_dns_infrastructure
@flotho flotho force-pushed the 18.0-mig-base_dns_infrastructure branch from 7c687d1 to fcc27a9 Compare November 21, 2025 15:55
@flotho
Copy link
Copy Markdown
Member Author

flotho commented Dec 12, 2025

Hi @pedrobaeza I'm reaching you to be informed of the procedure for merging.
Recently I've been accepted as PSC member for this repo.
What is the ceremonial for merging etc... ?
Regards

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Dec 12, 2025

Hi @flotho I was one of the reviewers of your request :)

You have two commands for launching (I put the slash separated for not launching them, but it comes all together):

  • / ocabot merge nobump|patch|minor|major: for launching the merge
  • / ocabot migration <module>: for annotating the migration in the migration issue

DorianMAG
DorianMAG reviewed Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, look good
functional test ok

Comment thread base_dns_infrastructure/demo/base_dns_infrastructure.xml Outdated
@flotho
Copy link
Copy Markdown
Member Author

flotho commented Dec 15, 2025

/ocabot migration base_dns_infrastructure

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 15, 2025
@flotho flotho requested a review from DorianMAG December 16, 2025 14:17
DorianMAG
DorianMAG approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flotho flotho requested a review from DorianMAG December 18, 2025 08:17
@flotho
Copy link
Copy Markdown
Member Author

flotho commented Dec 18, 2025

Hi @pedrobaeza , is it "legit" for me to merge this module ? Do I still need 2 positive reviews?
Regards

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Dec 18, 2025

Well, being this very specific, I wouldn't expect more reviews, so it may be OK to self-merge having green CI.

@flotho
Copy link
Copy Markdown
Member Author

flotho commented Dec 18, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 18, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-23-by-flotho-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b15bb22 into OCA:18.0 Dec 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 18, 2025

Congratulations, your PR was merged at d783f8c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorianMAG DorianMAG Awaiting requested review from DorianMAG

Assignees

No one assigned

Labels

merged 🎉 needs review

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@flotho @pedrobaeza @OCA-git-bot @DorianMAG @mymage