Skip to content

[16.0][IMP] mgmtsystem_evaluation: allow update feedback and note#770

Open
luisDIXMIT wants to merge 1 commit into
OCA:16.0from
dixmit:16.0-imp-mgmtsytem_evaluation2
Open

[16.0][IMP] mgmtsystem_evaluation: allow update feedback and note#770
luisDIXMIT wants to merge 1 commit into
OCA:16.0from
dixmit:16.0-imp-mgmtsytem_evaluation2

Conversation

@luisDIXMIT

@luisDIXMIT luisDIXMIT commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Before, in an evaluation, when we chose a template and then changed it, the feedback and note fields weren’t updated, even if we cleared their content, because the HTML fields kept <p><br/></p>.

@max3903 max3903 added this to the 16.0 milestone May 2, 2026
@max3903 max3903 self-assigned this Jun 27, 2026
@max3903 max3903 changed the title [16.0] [IMP] mgmsystem_evaluation: allow update feedback and note [16.0][IMP] mgmtsystem_evaluation: allow update feedback and note Jun 27, 2026
@max3903

max3903 commented Jun 27, 2026

Copy link
Copy Markdown
Member

@luisDIXMIT I get your point with the <p><br/></p> but are you fine with the following scenario:

  1. User sets the feedbacks and notes
  2. User changes the template --> Feedbacks and notes are lost as they get reset to the template value.

Maybe we could have: if record.feedback == '<p><br/></p>'

@luisDIXMIT luisDIXMIT force-pushed the 16.0-imp-mgmtsytem_evaluation2 branch from 9be5eef to 75e3e71 Compare June 29, 2026 06:35
@OCA-git-bot OCA-git-bot added the mod:mgmtsystem_evaluation Module mgmtsystem_evaluation label Jun 29, 2026
@luisDIXMIT

Copy link
Copy Markdown
Contributor Author

@luisDIXMIT I get your point with the <p><br/></p> but are you fine with the following scenario:

  1. User sets the feedbacks and notes
  2. User changes the template --> Feedbacks and notes are lost as they get reset to the template value.

Maybe we could have: if record.feedback == '<p><br/></p>'

Thanks for your review @max3903 now it is better, thanks!

@luisDIXMIT luisDIXMIT force-pushed the 16.0-imp-mgmtsytem_evaluation2 branch from 75e3e71 to 30ec1d7 Compare June 29, 2026 06:37
@luisDIXMIT luisDIXMIT force-pushed the 16.0-imp-mgmtsytem_evaluation2 branch from 30ec1d7 to 813d257 Compare June 29, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants