Porting 8.0 product_customer_code by hurrinico · Pull Request #122 · OCA/product-attribute

hurrinico · 2015-12-23T10:35:57Z

I've made a fork of #38 and rebase it

…s by customer code and name

eLBati · 2015-12-23T14:21:58Z

Please see travis

product_customer_code/product.py:27:1: F401 '_' imported but unused
product_customer_code/product_customer_code.py:27:1: F401 '_' imported but unused

hurrinico · 2015-12-23T14:39:19Z

@eLBati fixed

eLBati · 2015-12-23T16:41:20Z

@hurrinico please consider suggestions made since #38 (diff)

eLBati · 2015-12-23T16:42:27Z

Not imported python files should be removed

pedrobaeza · 2016-01-19T17:11:50Z

I think a better path is to use product_supplierinfo_for_customer module as base for the customer code instead of creating a new model.

eLBati · 2016-04-05T14:27:41Z

We are using product_customer_code in several 7.0 and 8.0 instances and I would prefer to keep the current structure, to avoid issues with the existing databases

pedrobaeza · 2016-04-05T14:29:28Z

OK, but we should merge both concepts in v9.

andhit-r · 2016-05-12T05:26:08Z

@hurrinico would you:

Adjust README.rst according to latest OCA guideline
Use simple header on every .py file

mikevhe18 · 2016-05-17T23:49:28Z

I've made some changes to increase coverage/coveralls, then also adjustments to version 8 and OCA guidelines.

[8.0] product customer code

coveralls · 2016-05-18T07:29:38Z

Coverage increased (+9.7%) to 80.938% when pulling d2793fa on hurrinico:rebase_product_attribute into 6a5bc1a on OCA:8.0.

eLBati · 2016-05-18T09:33:36Z

@hurrinico @mikevhe18 please see failing checks

************* Module product_customer_code
product_customer_code/__init__.py:1: [W7908(missing-newline-extrafiles), ] views/product_product_view.xml Missing newline
************* Module product_customer_code.__openerp__
product_customer_code/__openerp__.py:5: [C8106(manifest-version-format), ] Wrong Version Format "1.0" in manifest file. Regex to match: "(\d+.\d+.\d+.\d+.\d+)"

mikevhe18 · 2016-05-22T04:07:22Z

hello @hurrinico, i've fixed the code. Thanks in advance

Fix error Travis

coveralls · 2016-05-23T07:25:42Z

Coverage increased (+9.7%) to 80.938% when pulling 28eccbf on hurrinico:rebase_product_attribute into 6a5bc1a on OCA:8.0.

andhit-r · 2016-05-23T08:04:05Z

Tested functionality on runbot 👍

mikevhe18 · 2016-05-24T11:35:37Z

👍

andhit-r · 2016-06-07T11:17:29Z

Hi @OCA/product-maintainers would you kindly review this PR? Many thanks

mikevhe18 · 2016-06-10T07:12:24Z

Hello @pedrobaeza @eLBati, would you kindly review this PR again ?

dcoopennet · 2016-07-18T09:03:59Z

👍

eLBati · 2016-07-21T06:59:15Z

+This module does just like the product.supplierinfo but for customers instead. For instance it
+allows to have different references for the same product according to the customer.
+
+.. image:: product_customer_code/static/src/img/screenshot1.png


Please use figure like at https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

eLBati · 2016-07-21T08:04:46Z

A few comments then LGTM 👍

hurrinico · 2016-10-03T15:17:10Z

@eLBati i've made the requested fix

bealdav · 2016-10-03T16:29:54Z

tested LGTM for me 👍
off-topic Migration: in product.product view: 'Customer Code' tab name could replaced by 'Customer Infos' because other modules could extend custom informations (as name or any field)

pedrobaeza · 2016-10-03T16:39:09Z

Please check Travis status. Do we need to have a specific task for this?

eLBati · 2016-10-04T11:56:13Z

@pedrobaeza , @espo-tony is on the problem of duplicate key value violates unique constraint "product_template_uniq_prefix_code"

espo-tony · 2016-10-04T14:48:57Z

@pedrobaeza , @eLBati
Travis seems to raise an error while running a tes. More specifically, it returns a duplicate key value violates unique constraint "product_template_uniq_prefix_code" after invoking the copy method on the model product.product.

According to the tests and the analysis I performed, the issue doesn't look to depend on the module "product_customer_code". Instead, it looks like the duplication of a product.product record is not possible anymore because of a bug introduced by the modules 'product_code_builder' and 'product_code_builder_sequence'.

Please give a look to the PRs #181 , #182 for further informations on this bug and to review a possible solution to them (notice that solving those bugs, also the Travis errors remarked on this PR should be solved).

eLBati · 2017-05-30T08:43:30Z

For me this can be closed , as product_supplierinfo_for_customer is already available and overlapping with this.
See #236 (comment)

hurrinico · 2017-06-23T10:46:48Z

IMHO this can be closed

* [REL] replace __openerp__ for __manifest__ * [REL] replace openerp imports for odoo * [REL] some python3 exceptions * [REL] replace openerp by odoo on xml files * [REL] delete utf-8 line on python files * [REL] some minor fixes for migration to v11 * [FIX] runbot link

acysos added 3 commits December 23, 2015 10:58

product_customer_code: prepare field to migration

1a77661

[FIX] product_customer_code: migrated to 8.0 - Add search improvement…

939b81d

…s by customer code and name

[FIX] product_customer_code: fix flake8 error

8fc901e

hurrinico mentioned this pull request Dec 23, 2015

product_customer_code migrated to 8.0. Add search by customer code and name. #38

Closed

eLBati reviewed Dec 23, 2015
View reviewed changes

Comment thread product_customer_code/product.py Outdated

eLBati Dec 23, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not imported python files should be removed

hurrinico force-pushed the rebase_product_attribute branch from 6265f4a to 00cfc24 Compare January 5, 2016 16:51

[FIX] FIx flake8

dc57be4

hurrinico force-pushed the rebase_product_attribute branch from 00cfc24 to dc57be4 Compare January 7, 2016 08:28

eLBati mentioned this pull request Jan 13, 2016

ADD l10n_it_ddt_customer_code OCA/l10n-italy#173

Closed

hurrinico changed the title ~~Rebase of https://github.com/OCA/product-attribute/pull/38~~ Product Customer Code 8.0 Rebase of https://github.com/OCA/product-attribute/pull/38 Jan 13, 2016

hurrinico mentioned this pull request Jan 19, 2016

Product Customer Code Invoice version 8 OCA/account-invoicing#124

Closed

hurrinico mentioned this pull request Jan 21, 2016

[ADD] Add new Module product_customer_code_purchase OCA/purchase-workflow#206

Closed

renatonlima mentioned this pull request Mar 29, 2016

[8.0/Master] Any plans on porting product_customer_code to 8.0 soon? #28

Closed

andhit-r mentioned this pull request May 12, 2016

product_customer_code open-synergy/product-attribute#1

Closed

mikevhe18 added 3 commits May 14, 2016 15:56

[ADD] Adding unittest for copy and name_search

505ebe4

[UPD] Using short header and adding OCA icon

4223cf5

[UPD] Adjusting README.rst with OCA

f384fe4

mikevhe18 mentioned this pull request May 14, 2016

[8.0] product customer code hurrinico/product-attribute#1

Merged

Merge pull request #1 from mikevhe18/8.0-product_customer_code

d2793fa

[8.0] product customer code

Fix error Travis

1a56fa6

andhit-r mentioned this pull request May 22, 2016

product_customer_code_sale open-synergy/sale-workflow#1

Closed

Merge pull request #2 from mikevhe18/8.0-product_customer_code_rev

28eccbf

Fix error Travis

eLBati reviewed Jul 21, 2016
View reviewed changes

[FIX] Fix readme.rst

5751224

hurrinico force-pushed the rebase_product_attribute branch from 7fb5059 to 5751224 Compare October 3, 2016 15:16

StefanRijnhart mentioned this pull request Oct 12, 2016

8.0 porting product_customer_code_sale OCA/sale-workflow#345

Closed

hurrinico changed the title ~~Product Customer Code 8.0 Rebase of https://github.com/OCA/product-attribute/pull/38~~ Porting 8.0 product_customer_code Dec 23, 2016

cvinh mentioned this pull request Mar 22, 2017

[MGR] Migrated product_customer_code to version 10 #236

Closed

eLBati mentioned this pull request May 31, 2017

[8.0] porting product_customer_code picking OCA/stock-logistics-workflow#188

Closed

hurrinico closed this Jun 23, 2017

AaronHForgeFlow mentioned this pull request Jun 26, 2017

[REF] product_customer_code: Migrate module product_customer_code to new api #276

Closed

Uh oh!

Uh oh!

Conversation

hurrinico commented Dec 23, 2015

Uh oh!

eLBati commented Dec 23, 2015

Uh oh!

hurrinico commented Dec 23, 2015

Uh oh!

eLBati commented Dec 23, 2015

Uh oh!

eLBati Dec 23, 2015

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jan 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eLBati commented Apr 5, 2016

Uh oh!

pedrobaeza commented Apr 5, 2016

Uh oh!

andhit-r commented May 12, 2016

Uh oh!

mikevhe18 commented May 17, 2016

Uh oh!

coveralls commented May 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eLBati commented May 18, 2016

Uh oh!

mikevhe18 commented May 22, 2016

Uh oh!

coveralls commented May 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andhit-r commented May 23, 2016

Uh oh!

mikevhe18 commented May 24, 2016

Uh oh!

andhit-r commented Jun 7, 2016

Uh oh!

mikevhe18 commented Jun 10, 2016

Uh oh!

dcoopennet commented Jul 18, 2016

Uh oh!

eLBati Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

eLBati commented Jul 21, 2016

Uh oh!

hurrinico commented Oct 3, 2016

Uh oh!

bealdav commented Oct 3, 2016

Uh oh!

pedrobaeza commented Oct 3, 2016

Uh oh!

eLBati commented Oct 4, 2016

Uh oh!

espo-tony commented Oct 4, 2016

Uh oh!

eLBati commented May 30, 2017

Uh oh!

hurrinico commented Jun 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

pedrobaeza commented Jan 19, 2016 •

edited

Loading

coveralls commented May 18, 2016 •

edited

Loading

coveralls commented May 23, 2016 •

edited

Loading