Skip to content

[19.0][MIG] product_pricelist_fixed_currency_rate : Migration to 19.0.#2297

Open
uncannycs wants to merge 17 commits into
OCA:19.0from
uncannycs:19.0-mig-product_pricelist_fixed_currency_rate
Open

[19.0][MIG] product_pricelist_fixed_currency_rate : Migration to 19.0.#2297
uncannycs wants to merge 17 commits into
OCA:19.0from
uncannycs:19.0-mig-product_pricelist_fixed_currency_rate

Conversation

@uncannycs

Copy link
Copy Markdown

[19.0][MIG] product_pricelist_fixed_currency_rate : Migration to 19.0.

LoisRForgeFlow and others added 16 commits May 18, 2026 17:00
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/it/
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-18.0/product-attribute-18.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_pricelist_fixed_currency_rate/
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-18.0/product-attribute-18.0-product_pricelist_fixed_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_pricelist_fixed_currency_rate/it/
…doo 18

In Odoo 18, _compute_base_price() parameter was renamed from
'target_currency' to 'currency'. The old signature causes:
TypeError: ProductPricelist._compute_base_price() got an unexpected
keyword argument 'currency'

Fix: rename parameter to 'currency' to match parent method signature.

Closes: OCA#1831
@OCA-git-bot OCA-git-bot added series:19.0 mod:product_pricelist_fixed_currency_rate Module product_pricelist_fixed_currency_rate labels May 18, 2026
@uncannycs uncannycs force-pushed the 19.0-mig-product_pricelist_fixed_currency_rate branch from f245c4d to 3d3e540 Compare May 19, 2026 13:29
{
"name": "Product Pricelist Fixed Currency Rate",
"summary": "Set a fixed currency rate between pricelists",
"version": "19.0.1.0.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "19.0.1.0.1",
"version": "19.0.1.0.0",

from odoo.tests import common


class TestProductPricelistFixedCurrencyRate(common.TransactionCase):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TestProductPricelistFixedCurrencyRate(common.TransactionCase):
class TestProductPricelistFixedCurrencyRate(Basecommon):

Comment on lines +39 to +41
(
0,
0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
0,
0,
Command.create(

Comment on lines +58 to +60
(
0,
0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
0,
0,
Command.create(

Comment on lines +77 to +79
(
0,
0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
0,
0,
Command.create(

@uncannycs uncannycs force-pushed the 19.0-mig-product_pricelist_fixed_currency_rate branch from 823727a to bd716a1 Compare July 2, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:product_pricelist_fixed_currency_rate Module product_pricelist_fixed_currency_rate series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants