[FIX] product_category_code_unique: writing on many categories is broken.#2316
Open
legalsylvain wants to merge 1 commit into
Open
[FIX] product_category_code_unique: writing on many categories is broken.#2316legalsylvain wants to merge 1 commit into
legalsylvain wants to merge 1 commit into
Conversation
…ken. rational : with the current implementation, if we write on many categories, on categories that don't have code, it will write the same code on many categories
Contributor
|
Hi @luisg123v, @rousseldenis, |
OCA-git-bot
added
series:16.0
mod:product_category_code_unique
luisg123v
suggested changes
Jun 1, 2026
luisg123v
left a comment
luisg123v
left a comment
There was a problem hiding this comment.
Code LGTM, but commit message needs some adjustments:
- Missing blank line between title and description.
- Missing trailing dot in description, but title has an extra dot.
- Lines are too long, please wrap to 72 characters.
- rational → rationale
rvalyi
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rational : with the current implementation, if we write on many categories, on categories that don't have code, it will write the same code on many categories
Fixes CI of #2314