[19.0][MIG] hr_expense_tier_validation: Migration to 19.0#51
Open
dnplkndll wants to merge 29 commits into
Open
[19.0][MIG] hr_expense_tier_validation: Migration to 19.0#51dnplkndll wants to merge 29 commits into
dnplkndll wants to merge 29 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:hr_expense_tier_validation
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tier_validation
branch
from
87d2d39 to
a7024af
Compare
…m the expense report is under validation
…validate the tier validation, then the user has to click the Submit to Manager button. By this PR, requester has to click the Submit to Manager button first, then the tier validation is activated.
Currently translated at 100.0% (18 of 18 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (21 of 21 strings) Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_tier_validation Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_tier_validation/tr/
hr.expense.sheet was removed in 19.0; retarget tier validation to hr.expense.
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tier_validation
branch
from
a7024af to
5463183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
hr_expense_tier_validationfrom 18.0 to 19.0. Migration guide: https://github.com/OCA/maintainer-tools/wiki/#migration-to-version-19.0This module is re-filed here because the tier-validation family moved to its own
OCA/tier-validationrepo in 19.0 (it previously lived inOCA/hr-expense). Supersedes the 18.0-repo attempt at OCA/hr-expense#349; itsbase_tier_validationdependency now resolves within this repo.Non-mechanical adaptations worth flagging
hr.expense.sheetremoved in 19.0 — tier validation is retargeted fromhr.expense.sheettohr.expense(models/hr_expense_sheet.py→models/hr_expense.py,views/hr_expense_sheet_view.xml→views/hr_expense_views.xml, and the tier-definition model reference). Approval now lives on the expense record itself.