Skip to content

Ensured plain string first arguments for logging #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jekuaitk merged 4 commits into from
Apr 9, 2026
Merged

Ensured plain string first arguments for logging #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb4d3a6
Ensured plain string first arguments for logging
jekuaitk Apr 9, 2026
75c2545
Updated CHANGELOG
jekuaitk Apr 9, 2026
b79c816
Updated pr workflow
jekuaitk Apr 9, 2026
f323ee0
Ensured placeholders take precedence in case of key collisions
jekuaitk Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ jobs:

# Make Drupal 10 compatible
composer --working-dir=drupal --no-interaction require psr/http-message:^1.0
composer --working-dir=drupal --no-interaction require 'mglaman/composer-drupal-lenient'
composer --working-dir=drupal --no-interaction require 'mglaman/composer-drupal-lenient':'^1.0'
composer --working-dir=drupal config --no-plugins --merge --json extra.drupal-lenient.allowed-list '["drupal/coc_forms_auto_export", "drupal/webform_node_element"]'

# Require our module.
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ about writing changes to this log.

## [Unreleased]

## [2.1.1] 09.04.2026

* Ensured static strings as first argument for logging calls.

## [2.1.0] 11.12.2025

* Allowed `os2forms/os2forms` `5.x`.
Expand Down Expand Up @@ -77,7 +81,8 @@ about writing changes to this log.

## [1.0.0] 29.03.2023

[Unreleased]: https://github.com/OS2Forms/os2forms_get_organized/compare/2.1.0...HEAD
[Unreleased]: https://github.com/OS2Forms/os2forms_get_organized/compare/2.1.1...HEAD
[2.1.1]: https://github.com/OS2Forms/os2forms_get_organized/compare/2.1.0...2.1.1
[2.1.0]: https://github.com/OS2Forms/os2forms_get_organized/compare/2.0.1...2.1.0
[2.0.1]: https://github.com/OS2Forms/os2forms_get_organized/compare/2.0.0...2.0.1
[2.0.0]: https://github.com/OS2Forms/os2forms_get_organized/compare/1.4.1...2.0.0
Expand Down
6 changes: 3 additions & 3 deletions src/Plugin/AdvancedQueue/JobType/ArchiveDocument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ public function process(Job $job): JobResult {

try {
$this->helper->archive($payload['submissionId'], $payload['handlerConfiguration']);
$this->submissionLogger->notice($this->t('The submission #@serial was successfully delivered', ['@serial' => $webformSubmission->serial()]), $logger_context);
$this->submissionLogger->notice('The submission #@serial was successfully delivered', ['@serial' => $webformSubmission->serial()] + $logger_context);

return JobResult::success();
}
catch (\Exception $e) {
$this->submissionLogger->error($this->t('The submission #@serial failed (@message)', [
$this->submissionLogger->error('The submission #@serial failed (@message)', [
'@serial' => $webformSubmission->serial(),
'@message' => $e->getMessage(),
]), $logger_context);
] + $logger_context);

return JobResult::failure($e->getMessage());
}
Expand Down
2 changes: 1 addition & 1 deletion src/Plugin/WebformHandler/GetOrganizedWebformHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ public function postSave(WebformSubmissionInterface $webform_submission, $update
'operation' => 'submission queued',
];

$this->submissionLogger->notice($this->t('Added submission #@serial to queue for processing', ['@serial' => $webform_submission->serial()]), $logger_context);
$this->submissionLogger->notice('Added submission #@serial to queue for processing', ['@serial' => $webform_submission->serial()] + $logger_context);
}

/**
Expand Down
Loading