Fix variable shadowing bug in leccalc aggreports#406
Merged
Conversation
Remove inner redeclaration of fileIDs that shadowed the outer variable, causing it to remain empty after the if block. Fixes #405 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SkylordA
approved these changes
May 27, 2026
SkylordA
left a comment
SkylordA
left a comment
Contributor
There was a problem hiding this comment.
Not sure if you want to fix the workflow file issue here as well for macos since it's failing the build. I think it's because macos-13 isn't supported anymore on git
benhayes21
force-pushed
the
fix/405-variable-shadowing-leccalc
branch
from
June 16, 2026 20:33
d4646c0 to
a2345f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix variable shadowing bug in leccalc aggreports
leccalc/aggreports.cppwherefileIDswas redeclared inside anifblock, shadowing the outer variable and leaving it empty when passed toWritePerSampleExceedanceProbabilityTable#405