This repository was archived by the owner on Jun 26, 2025. It is now read-only.
Enabling TinyTypes for primary keys#28
Merged
Merged
Conversation
… in parallel until all things are migrated
…, and drop the generics constraint to CaseInsensitiveTinyType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to IId and IDocument to support TinyTypes as primary keys.
There is no CaseInsensitiveStringTinyType constraint on the generics at the moment to make transition easier. While we're moving, all existing things can be seen as IId
UserId has moved out to MessageContracts and is the initial test case in server. Data now takes a dependency on MessageContracts.
Depends on
OctopusDeploy/Nevermore#149
OctopusDeploy/Server.MessageContracts#15