Support for strongly typed string keys (Id property)#146
Draft
slewis74 wants to merge 4 commits into
Draft
Conversation
…d be taking care of this
… custom property handler as well as a TypeHandler
…so the expected type is passed through the callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft for discussion around the concept of supporting strongly typed keys (e.g. TinyTypes).
Nevermore already has support for these types in most columns, through the use of Type Handlers. This investigation was around working out what it might take to support their use as an
Id.The end result has been minimially invasive to Nevermore, and should require no further configuration by consumers.
The core implementation changes of interest were to the following classes:
Implementation Assumptions:
ToStringto returnValue. The places passing the value to a DB Parameter need this because that requires an intrinsic typeTODO:
WriteTransaction.AllocateIdrelies on some reflection that may get expensive at scale, a cache should be added.