Removed string based API from the mapping API#152
Merged
Conversation
slewis74
approved these changes
Jun 21, 2021
Contributor
slewis74
left a comment
slewis74
left a comment
There was a problem hiding this comment.
Very nice, I was trying to stay too close to the original idea for IdPrefix etc, this is much tidier 👍
One question inline about a virtual on the Type property.
| public abstract class PrimaryKeyHandler<T> : IPrimaryKeyHandler | ||
| { | ||
| public Type Type => typeof(T); | ||
| public virtual Type Type => typeof(T); |
Contributor
There was a problem hiding this comment.
Does this need to be virtual? It is only meant to represent the underlying type, so I'm not sure it'd be a good idea for an inheriting class to override it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #149 and changes 2 things:
KeyHandlerwas assigned for documents with custom prefixFormatandPrefixand move where they belong, which is specificKeyHandlersThis is a breaking change. That being said Octofront doesn't use
IdPrefixand most of the cases in the server can be simply removed as the duplicate what Nevermore already does internally.