-
Notifications
You must be signed in to change notification settings - Fork 10
Allows use of externally owned transactions for writes #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ namespace Nevermore | |
| { | ||
| public interface IWriteTransaction : IReadTransaction, IWriteQueryExecutor | ||
| { | ||
| void CommitIfOwned(); | ||
| Task CommitIfOwnedAsync(CancellationToken cancellationToken = default); | ||
|
Comment on lines
+8
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per the feedback on https://github.com/OctopusDeploy/OctopusDeploy/pull/23120, we'd rather not introduce a different way to commit a Nevermore transaction. Rather, the consumer (Octopus Server) should be aware of whether the SQL transaction is externally owned and simply not call |
||
| void Commit(); | ||
| Task CommitAsync(CancellationToken cancellationToken = default); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.