This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Change from package to local references#89
Open
tothegills wants to merge 14 commits into
Open
Conversation
… Membership Overages
Merging Google Auth Changes
- More logging - PowerShell script for .dll dependency copy into CustomExtensions folder - Sanity checks and polish
…'t present. Also added more error logging on the GraphAPI call.
Updating Repo from upstream changes
benPearce1
reviewed
Apr 3, 2023
| # Run this script after installing a new version of Octopus Server, but before starting it (due to file lock and dependency load issues). | ||
|
|
||
| $OctopusServerBinaryLocation = "E:\Program Files\Octopus Deploy\Octopus" # Make sure this points to where you install the Octopus Server binaries | ||
| $OctopusServerCustomExtensionsLocation = "C:\ProgramData\Octopus\CustomExtensions\" # This should always point to where the Octopus Server CustomExtenions folder lives |
Contributor
There was a problem hiding this comment.
This could be $env:PROGRAMDATA
benPearce1
reviewed
Apr 3, 2023
|
|
||
| <ItemGroup> | ||
| <Reference Include="Octopus.Server.Client"> | ||
| <HintPath>C:\Program Files\Octopus Deploy\Octopus\Octopus.Server.Client.dll</HintPath> |
Contributor
There was a problem hiding this comment.
The HintPath breaks non-Windows development.
Perhaps this should be a local file reference with the binary included in the repo (not ideal)
benPearce1
reviewed
Apr 3, 2023
| RoleClaimType = DefaultRoleClaimType; | ||
| } | ||
|
|
||
| public SensitiveString? ClientKey { get; set; } |
Contributor
There was a problem hiding this comment.
Not sure how these changes relate to the PR?
Contributor
|
Nice one @tothegills , good to see these changes merge in finally 🎉. Onwards to deprecation! |
Contributor
Author
|
This PR allows AETNA/CVS to rebuild their custom plugin and upgrade to 2023.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Octopus to the default location (C:\Program Files\Octopus Deploy\Octopus). Load the solution, and the references should all line up with the installed version of Octopus.