Conversation
potuz
force-pushed
the
riscv
branch
5 times, most recently
from
86a7636 to
46a7652
Compare
potuz
force-pushed
the
riscv
branch
2 times, most recently
from
a3bd434 to
0465811
Compare
james-prysm
reviewed
Apr 8, 2026
| target | ||
| build | ||
| tests | ||
| .gitignore |
Contributor
There was a problem hiding this comment.
why does gitignore , ignore git ignore lol
Collaborator
Author
There was a problem hiding this comment.
I made the mistake of adding it early on. Lazy to remove it now
james-prysm
reviewed
Apr 8, 2026
james-prysm
reviewed
Apr 8, 2026
|
Could we add benchmark numbers/results to readme (if available)? |
satushh
reviewed
Apr 8, 2026
| @@ -0,0 +1,6 @@ | |||
| //go:build riscv64 | |||
There was a problem hiding this comment.
Should the tags be same in both wrapper and binding files? As one mentions linux and other doesn't
Collaborator
Author
Added the only ones I have on 6ff8671, don't have a board anymore and I never had one with crypto extensions to bench |
- Base RV64I arithmetic assembly - No Zb nor Vector extensions - Naive implementation 1 block at a time and no pipelining for scheduling
- Add RISC-V 64 target to CI workflow with QEMU emulation - Add riscv_hwprobe syscall for runtime CPU feature detection - Detect Zknh+Zbkb for crypto, Zbb for bit manipulation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add bindings_riscv64.go with supportedCPU=false (falls back to generic Go implementation until .syso file is added) - Add RISC-V to go-bindings CI matrix with QEMU testing - Cross-compile and test Go bindings on RISC-V using qemu-riscv64 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add build-syso.yml workflow that builds syso files for all platforms: - Linux x86 (hashtree_amd64.syso) - macOS arm64 (hashtree_darwin_arm64.syso) - Linux arm64 (hashtree_linux_arm64.syso) - Windows x86 (hashtree_windows_amd64.syso) - Linux RISC-V 64 (hashtree_linux_riscv64.syso) - Workflow commits syso files back to the repo - Triggers on any branch when src/ changes, or manual dispatch - Enable native RISC-V support in bindings_riscv64.go 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use CGO_ENABLED=1 with the cross-compiler to properly link the RISC-V syso file when building the test binary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Bridges Go's HashtreeHash function to the C library's hashtree_hash, which handles runtime CPU feature detection internally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
james-prysm
approved these changes
Apr 8, 2026
Contributor
james-prysm
left a comment
james-prysm
left a comment
There was a problem hiding this comment.
I tried to review the best I can without much knowledge in assembly, with ai assistance it seems things are isolated and I trust that potuz has made the right implementation. Nothing was ran manually in this review. symbolically approving allowing potuz to make best judgement on this repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #41
h/t to @washosk for lending me a metal board access.