Skip to content

Enable http communication between block validator and validation server#4499

Merged
pmikolajczyk41 merged 2 commits intomasterfrom
pmikolajczyk/nit-4652-http-in-block-validator
Mar 17, 2026
Merged

Enable http communication between block validator and validation server#4499
pmikolajczyk41 merged 2 commits intomasterfrom
pmikolajczyk/nit-4652-http-in-block-validator

Conversation

@pmikolajczyk41
Copy link
Copy Markdown
Member

One of the minor changes we had to do to make nitro <-> JIT server communication work, was enabling http connection in the block validator (see https://github.com/OffchainLabs/nitro/pull/4497/changes). Since the underlying rpcclient.RpcClient supports both protocols, this requires only relaxing configuration validation. Proved to work well in #4497.


closes NIT-4652

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.75%. Comparing base (d7fe12c) to head (5bc2b59).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4499      +/-   ##
==========================================
- Coverage   34.56%   32.75%   -1.81%     
==========================================
  Files         495      495              
  Lines       58648    58648              
==========================================
- Hits        20272    19212    -1060     
- Misses      34772    36074    +1302     
+ Partials     3604     3362     -242     

@github-actions
Copy link
Copy Markdown
Contributor

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
4370 4 4366 0
View the top 3 failed tests by shortest run time
TestRedisProduceComplex/one_producer,_all_consumers_are_active
Stack Traces | 1.270s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[03-12|08:54:58.559] consumer: xdel                           �[36mcid�[0m=b249fd00-40c0-468c-9b1d-acea756c4097 �[36mmessageId�[0m=1773305697408-4
�[36mDEBUG�[0m[03-12|08:54:58.564] consumer: xdel                           �[36mcid�[0m=d59f1182-729d-4536-b35b-a4b28d2b2c8f �[36mmessageId�[0m=1773305697408-0
�[36mDEBUG�[0m[03-12|08:54:58.564] consumer: xdel                           �[36mcid�[0m=69b49c35-59c7-419e-8b9f-6ffab703fd34 �[36mmessageId�[0m=1773305697409-1
�[36mDEBUG�[0m[03-12|08:54:58.564] consumer: xdel                           �[36mcid�[0m=35bb1760-03dd-49a3-9521-1deee88259ca �[36mmessageId�[0m=1773305697407-7
�[36mDEBUG�[0m[03-12|08:54:58.564] consumer: xdel                           �[36mcid�[0m=77d62457-feb4-424a-bf37-86c0ca547177 �[36mmessageId�[0m=1773305697409-0
�[36mDEBUG�[0m[03-12|08:54:58.604] checkResponses                           �[36mresponded�[0m=79 �[36merrored�[0m=0 �[36mchecked�[0m=98
�[36mDEBUG�[0m[03-12|08:54:58.614] redis producer: check responses starting
�[36mDEBUG�[0m[03-12|08:54:58.643] checkResponses                           �[36mresponded�[0m=19 �[36merrored�[0m=0 �[36mchecked�[0m=19
�[31mERROR�[0m[03-12|08:54:58.645] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.647] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[36mDEBUG�[0m[03-12|08:54:58.648] redis producer: check responses starting
�[36mDEBUG�[0m[03-12|08:54:58.649] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=0
�[31mERROR�[0m[03-12|08:54:58.649] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.651] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.651] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.651] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.652] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[31mERROR�[0m[03-12|08:54:58.652] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
    pubsub_test.go:408: mergeMaps() unexpected error: duplicate key: 1773305697391-2
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.27s)
TestVersion40
Stack Traces | 8.690s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
ERROR[03-12|09:05:48.705] ExecuteNextMsg failed to get exec engine head message index err="context canceled"
INFO [03-12|09:05:48.705] Writing cached state to disk             block=1   hash=9921ac..9c02bc root=d45d64..4e7811
WARN [03-12|09:05:48.706] Error getting finalizedMessageCount from syncMonitor err="block number not supported: finalized block not found"
INFO [03-12|09:05:48.706] Persisted trie from memory database      nodes=23  flushnodes=0 size=3.61KiB   flushsize=0.00B time="268.339µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.412µs"   livenodes=0    livesize=0.00B
INFO [03-12|09:05:48.706] Writing cached state to disk             block=1   hash=9921ac..9c02bc root=d45d64..4e7811
INFO [03-12|09:05:48.706] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time="1.062µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-12|09:05:48.706] Writing snapshot state to disk           root=28fb26..40a768
INFO [03-12|09:05:48.706] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=571ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [03-12|09:05:48.706] Blockchain stopped
INFO [03-12|09:05:48.706] Submitted transaction                    hash=0x589d4612f3f88196225978d7df6110cd348155a9919326f584fb381ab29c9d9e from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=151  recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
INFO [03-12|09:05:48.707] InboxTracker                             sequencerBatchCount=10  messageCount=13   l1Block=40  l1Timestamp=2026-03-12T09:05:48+0000
INFO [03-12|09:05:48.707] releasing chosen one                     myUrl=/home/runner/work/nitro/nitro/target/tmp/deadbeefbee/1506493533/0.ipc attempt=2
WARN [03-12|09:05:48.707] unable to verify sequencer release status due to Redis error: %v "!BADKEY"="redis: client is closed" "!BADKEY"=&lt;nil&gt;                     LOG_ERROR="Normalized odd number of arguments by adding nil"
ERROR[03-12|09:05:48.707] failed to release chosen one status on shutdown err="redis: client is closed"
--- FAIL: TestVersion40 (8.69s)
TestRedisProduceComplex
Stack Traces | 21.300s run time
=== RUN   TestRedisProduceComplex
=== PAUSE TestRedisProduceComplex
=== CONT  TestRedisProduceComplex
--- FAIL: TestRedisProduceComplex (21.30s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@eljobe eljobe added this pull request to the merge queue Mar 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026
@pmikolajczyk41 pmikolajczyk41 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into master with commit 522b71e Mar 17, 2026
28 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk/nit-4652-http-in-block-validator branch March 17, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants