Enable http communication between block validator and validation server#4499
Merged
pmikolajczyk41 merged 2 commits intomasterfrom Mar 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4499 +/- ##
==========================================
- Coverage 34.56% 32.75% -1.81%
==========================================
Files 495 495
Lines 58648 58648
==========================================
- Hits 20272 19212 -1060
- Misses 34772 36074 +1302
+ Partials 3604 3362 -242 |
Contributor
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
eljobe
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the minor changes we had to do to make nitro <-> JIT server communication work, was enabling http connection in the block validator (see https://github.com/OffchainLabs/nitro/pull/4497/changes). Since the underlying
rpcclient.RpcClientsupports both protocols, this requires only relaxing configuration validation. Proved to work well in #4497.closes NIT-4652