Use proposer preferences cache for payload attributes after Gloas#16620
Merged
terencechain merged 3 commits intodevelopfrom Apr 8, 2026
Merged
Use proposer preferences cache for payload attributes after Gloas#16620terencechain merged 3 commits intodevelopfrom
terencechain merged 3 commits intodevelopfrom
Conversation
When constructing payload attributes for FCU, check the ProposerPreferencesCache (populated via Gloas gossip) for fee recipient before falling back to TrackedValidatorsCache or the PrepareAllPayloads default. This ensures payloads built with the --builder flag use the correct fee recipient after the Gloas fork. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
james-prysm
approved these changes
Apr 7, 2026
Contributor
james-prysm
left a comment
james-prysm
left a comment
There was a problem hiding this comment.
another thing to remember when addressing #16545
I'm ok for now if this speeds things up on development side
terencechain
reviewed
Apr 7, 2026
| if pref, ok := s.proposerPreference(slot); ok { | ||
| return pref, true | ||
| } | ||
| return val, val.Active |
Collaborator
There was a problem hiding this comment.
Because we added GasLimit to TrackedValidator, im not sure here before return val, val.Active, you want to set val.GasLimit to DefaultBuilderGasLimit as a fallback.
The concern is pre mature, but i think is a valid one. Also ok if no action is taken
| @@ -0,0 +1,2 @@ | |||
| ### Fixed | |||
Collaborator
There was a problem hiding this comment.
I dont think it's Fixed. It hsould be Added or Changed.. This isn't fixing a bug, it's adding new functionality 🐵
terencechain
approved these changes
Apr 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProposerPreferencesCacheto the blockchain service sotrackedProposer()can use Gloas gossip preferences (fee recipient, gas limit) when constructing payload attributes for FCUPrepareAllPayloadsis enabled, checks the preferences cache first, falling back to the default burn addressGasLimitfield toTrackedValidatorstruct, populated from proposer preferences