Skip to content

Unplacement fix #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ollson2921 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unplacement fix #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545079f
fix and test for unplacement
Ollson2921 May 22, 2026
bd2bcc8
remove prints
Ollson2921 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mapplings/cleaners/unplacement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def implied_point_obs(self) -> Iterator[GriddedCayleyPerm]:
pos = sorted(cells)
pattern = (pos[0][1] > pos[1][1], pos[1][1] > pos[0][1])
gcp = GriddedCayleyPerm(pattern, pos)
if self.param.map.map_gridded_cperm(gcp) not in self.base_obs:
if not self.param.map.map_gridded_cperm(gcp).avoids(self.base_obs):
yield GriddedCayleyPerm((0,), (cells[0],))

@cached_property
Expand Down
170 changes: 170 additions & 0 deletions tests/cleaner/mappling_cleaner/test_unplacement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
from mapplings.cleaners import MTCleaner
from mapplings import MappedTiling, ParameterList, Parameter
from gridded_cayley_permutations import GriddedCayleyPerm, RowColMap, Tiling
from cayley_permutations import CayleyPermutation


def test_unplacement_on_rgfs_param():
"""Mappling with the rgfs param as an avoider, test full cleaning doesn't
fully unplace all points and counts are the same."""
rgfs_mt = MappedTiling(
Tiling(
(
GriddedCayleyPerm(
CayleyPermutation((0, 1, 0, 0)), ((0, 0), (0, 0), (0, 0), (0, 0))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1, 2, 1, 0)),
((0, 0), (0, 0), (0, 0), (0, 0), (0, 0)),
),
),
(),
(1, 1),
),
ParameterList(
frozenset(
{
Parameter(
Tiling(
(
GriddedCayleyPerm(CayleyPermutation((0,)), ((0, 1),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((1, 0),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((1, 1),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((1, 2),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((1, 4),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((3, 0),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((3, 2),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((3, 3),)),
GriddedCayleyPerm(CayleyPermutation((0,)), ((3, 4),)),
GriddedCayleyPerm(
CayleyPermutation((0, 0)), ((1, 3), (1, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 0)), ((3, 1), (3, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((0, 3), (0, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((0, 3), (1, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((0, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((0, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((1, 3), (1, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((1, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((1, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((2, 1), (2, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((2, 1), (3, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((2, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((2, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((2, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((3, 1), (3, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((3, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((4, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((0, 1)), ((4, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((0, 3), (0, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((0, 3), (1, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((0, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((0, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((1, 3), (1, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((1, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((1, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((2, 1), (2, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((2, 1), (3, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((2, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((2, 3), (2, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((2, 3), (4, 3))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((3, 1), (3, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((3, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((4, 1), (4, 1))
),
GriddedCayleyPerm(
CayleyPermutation((1, 0)), ((4, 3), (4, 3))
),
),
(
(
GriddedCayleyPerm(
CayleyPermutation((0,)), ((1, 3),)
),
),
(
GriddedCayleyPerm(
CayleyPermutation((0,)), ((3, 1),)
),
),
),
(5, 5),
),
RowColMap(
{0: 0, 1: 0, 2: 0, 3: 0, 4: 0},
{0: 0, 1: 0, 2: 0, 3: 0, 4: 0},
),
)
}
)
),
(),
(),
)

cleaned = MTCleaner.full_cleanup(rgfs_mt)
for i in range(5):
assert rgfs_mt.get_terms(i)[()] == cleaned.get_terms(i)[()]
Loading