Param strategies#68
Draft
ReedActon wants to merge 47 commits into
Draft
Conversation
Additionally, the index attribute added to functions no longer has a custom name
update from main
Made tox work, dealt with unregistered functions.
I'm confused as to why this is necessary, but here we are.
Add types-tabulate to mypy dependencies
Made the display prettier and added mappling specific strategies.
…into cleaner-log
Final display changes and tox
Added param placement and param insertion
Added stretegies to get the cursed tree
Made adjustments to avoider/container exorcism. Added ParameterInsertionFactory.
Added checks to param insertion strategy. Fixed a bug in IL factoring. Fixed a bug in try to kill. New pack to get 123 tree.
christianbean
requested changes
Dec 17, 2025
Collaborator
christianbean
left a comment
christianbean
left a comment
There was a problem hiding this comment.
I think the param placement and insertion strategies are looking good. Most of my comments are about tidying up all the miscellaneous files you also committed.
Comment on lines
+168
to
+171
| if cell2 not in self.cells_dict: | ||
| print(cell, cell2) | ||
| print(self.tiling) | ||
| print(gcp) |
Collaborator
There was a problem hiding this comment.
you forgot to remove this
| return all_factors | ||
|
|
||
|
|
||
| class ILFactorNormal(Factor): |
Collaborator
There was a problem hiding this comment.
This could be a could chance to change the names to something more descriptive.
To start brainstorming, I propose InterleavingFactor and CayleyInterleavingFactor. Open to other suggestions.
Comment on lines
+23
to
+25
| # ParamPlacementFactory, | ||
| # AvoiderExorcismFactory, | ||
| # ParameterInsertionFactory, |
Collaborator
There was a problem hiding this comment.
this was left by mistake?
| iterative=False, | ||
| ) | ||
|
|
||
| @classmethod |
Collaborator
There was a problem hiding this comment.
is there a point to this pack, or should it just be deleted?
| iterative=False, | ||
| ) | ||
|
|
||
| @classmethod |
Collaborator
There was a problem hiding this comment.
Do we want to remove these changes to ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented Parameter Placement.
Added parameter placement strategies and factories.
Added parameter insertion strategies.
Added "Exorcism" strategies and factories.
New playground with the cursed tree.