Skip to content

fix(docs): make the docs site build again (MDX error in a spec) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
welsbach merged 1 commit into from
Oct 22, 2026
Merged

fix(docs): make the docs site build again (MDX error in a spec) #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/specs/review-json-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
The review runtime (`.github/asdd/runtime/generic.sh` via `openai-compat.sh`) asks the model for a bare
JSON object and then requires the raw response to parse as that object. A reasoning-capable model rarely
complies exactly: it returns a paragraph of analysis before the object, wraps the object in a
` ```json ` fence, or adds trailing commentary. That analysis usually contains its own braces (`def f()
{ ... }`, `{x: 1}`), so the previous "strip fences, else slice from the first `{` to the last `}`"
` ```json ` fence, or adds trailing commentary. That analysis usually contains its own braces (`def f() { ... }`, `{x: 1}`), so the previous "strip fences, else slice from the first `{` to the last `}`"
recovery captured a span that was not valid JSON. The adapter then treated a perfectly good review as
unparseable, retried, and finally fell back to a `live` placeholder: "The review runtime returned invalid
output; a human should review manually." The agent had reviewed; its verdict was thrown away.
Expand Down
Loading