fix: handle wc: URI parsing failure in Android WebView deeplink handler#10936
Open
FarooqMulla wants to merge 36 commits intoOneKeyHQ:xfrom
Open
fix: handle wc: URI parsing failure in Android WebView deeplink handler#10936FarooqMulla wants to merge 36 commits intoOneKeyHQ:xfrom
FarooqMulla wants to merge 36 commits intoOneKeyHQ:xfrom
Conversation
expo-linking fails to parse wc:TOPIC@2?... URIs on Android because the @2 version marker makes it a non-standard URL structure. When query param parsing yields nothing, fall back to using the raw URL directly if it contains the v2 marker (@2?), allowing the WalletConnect pairing to proceed. Fixes OneKeyHQ#6804
FarooqMulla
requested review from
ezailWang,
huhuanming,
originalix,
revan-zhang and
sidmorizon
as code owners
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expo-linking fails to parse wc:TOPIC@2?... URIs on Android because the @2 version marker makes it a non-standard URL structure. When query param parsing yields nothing, fall back to using the raw URL directly if it contains the v2 marker (@2?), allowing the WalletConnect pairing to proceed.
Fixes #6804