Skip to content

Support v2 page-memory chunks#125

Merged
suguanYang merged 4 commits into
mainfrom
feat/wangbinqi/v2-page-memory-api
Jul 2, 2026
Merged

Support v2 page-memory chunks#125
suguanYang merged 4 commits into
mainfrom
feat/wangbinqi/v2-page-memory-api

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • create Knowhere clients with API v2 so notebook uploads use the page-memory ingestion API when the SDK supports it
  • normalize page chunks with contentSource, readable page-summary content, metadata.entities, and page-number ranges
  • update parsed chunk cards and chunks panel display so page chunks render as page summaries and page assetUrl values are not treated as images
  • add tests covering normalization, model labels/ranges, card rendering, and client construction

Notes

Verification

  • pnpm install --frozen-lockfile --ignore-scripts
  • pnpm run typecheck
  • pnpm run lint
  • pnpm test (588 passed, 14 skipped; existing jsdom navigation warning still appears)
  • pnpm run build (passed; existing Next lockfile SWC patch and QStash token warnings still appear, generated lockfile patch not committed)
  • git diff --check

@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jul 2, 2026 7:19am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Preview Jul 2, 2026 7:19am

Request Review

@suguanYang

Copy link
Copy Markdown
Contributor Author

Follow-up update for the v2-only direction:

  • Notebook now depends on @ontos-ai/knowhere-sdk@^2.0.0.
  • Removed the apiVersion: "v2" constructor shim; Notebook relies on the SDK v2-only client behavior.

Local validation:

  • ./node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/eslint
  • ./node_modules/.bin/vitest run (588 passed, 14 skipped)
  • ./node_modules/.bin/next build
  • git diff --check

Remote status on commit 7fe9026: CodeQL is green, but Lint, Typecheck, Test, Build and the staging Vercel deployment fail at dependency install because package.json now requires @ontos-ai/knowhere-sdk@^2.0.0 while the committed lockfile still resolves ^0.10.0. I did not refresh the lockfile because @ontos-ai/knowhere-sdk@2.0.0 is not published yet; after the SDK PR publishes 2.0.0, the lockfiles need to be refreshed and this PR re-run.

@suguanYang
suguanYang merged commit 781aa8c into main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant