Skip to content

Harden chat assets on demand#129

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chat-asset-hardening-remote-sources
Jul 5, 2026
Merged

Harden chat assets on demand#129
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chat-asset-hardening-remote-sources

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • Harden chat and citation assets one at a time through Notebook Blob instead of full durable chunk reads.
  • Stop display chunk reads from requesting durable asset URLs; chat hardens only returned assets.
  • Refresh localized remote sources after remote chunks load, preserve selection, and fail missing Knowhere reconcile jobs cleanly.

Verification

  • pnpm test 'src/app/api/sources/[sourceId]/chunks/route.test.ts' src/components/workspace-selected-chunks.test.ts src/components/workspace-source-state.test.ts src/domains/chat/index.test.ts src/domains/chat/media-asset-hardening.test.ts src/domains/chat/media-assets.test.ts src/domains/chat/page-citation-assets.test.ts src/domains/chat/route-service.test.ts src/domains/chunks/read.test.ts src/domains/sources/source-reconcile-workflow.test.ts\n- pnpm typecheck (exit 0; existing Effect diagnostic TS47 in src/domains/sources/counts.ts)\n- git diff --cached --check

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jul 5, 2026 2:03pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Jul 5, 2026 2:03pm

Request Review

@suguanYang
suguanYang merged commit 81b3e19 into staging Jul 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant