Skip to content

Fix source selection, archive idempotency, and Gemini tool metadata#132

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chat-asset-hardening-remote-sources
Jul 5, 2026
Merged

Fix source selection, archive idempotency, and Gemini tool metadata#132
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/chat-asset-hardening-remote-sources

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • keep explicit stale or pending source selections from falling back to unrelated ready documents
  • treat Knowhere document-not-found archive responses as idempotent so local source deletion can complete
  • strip provider metadata from tool-result continuation messages while preserving assistant tool-call metadata for Gemini thought signatures

Tests

  • pnpm exec vitest run src/components/workspace-source-state.test.ts src/domains/sources/route-service.test.ts src/agent-harness/runtime.test.ts
  • pnpm exec vitest run src/components/workspace-source-workflow.test.ts src/components/workspace-selected-chunks.test.ts src/components/workspace-shell.test.ts src/domains/chat/index.test.ts
  • pnpm lint
  • pnpm run typecheck

Note: typecheck passes and prints the existing Effect diagnostic in src/domains/sources/counts.ts about Effect.void.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jul 5, 2026 3:53pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Jul 5, 2026 3:53pm

Request Review

@suguanYang
suguanYang merged commit a880548 into staging Jul 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant