Skip to content

Attach notebook client metadata on Knowhere job creates#139

Merged
suguanYang merged 1 commit into
stagingfrom
feat/wangbinqi/oss-telemetry-client-metadata
Jul 13, 2026
Merged

Attach notebook client metadata on Knowhere job creates#139
suguanYang merged 1 commit into
stagingfrom
feat/wangbinqi/oss-telemetry-client-metadata

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • Centralize notebook official-client metadata defaults.
  • Attach created_by_client=notebook on upload/retry job creates for OSS telemetry attribution.

Cross-repo tracking: Ontos-AI/knowhere#213

Test plan

  • Run document-metadata, upload, and retry unit tests
  • Confirm caller overrides still win for metadata keys

Made with Cursor

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jul 13, 2026 5:52pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Preview Jul 13, 2026 5:52pm

Request Review

@suguanYang

Copy link
Copy Markdown
Contributor Author

Retargeted base branch to staging per repo convention.

Share official-client defaults for created_by_client so OSS telemetry can attribute notebook uploads without leaking document content.

Co-authored-by: Cursor <cursoragent@cursor.com>
@suguanYang
suguanYang force-pushed the feat/wangbinqi/oss-telemetry-client-metadata branch from 6ecbc9b to df83e1b Compare July 13, 2026 17:50
@suguanYang
suguanYang merged commit 19bd88b into staging Jul 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant