GDB-14591 Add encryption at rest properties#207
Open
vanxa wants to merge 5 commits into
Open
Conversation
vanxa
requested review from
mihailradkov,
simonzhekoff,
tonyKunchev and
viktor-ribchev
vanxa
force-pushed
the
GDB-14591-encryption-at-rest
branch
from
0e4d473 to
49beff7
Compare
mihailradkov
requested changes
May 28, 2026
mihailradkov
reviewed
Jun 8, 2026
| GRAPHDB_DATA_ENCRYPTION_TYPE: {{ .Values.configuration.encryption.type }} | ||
| GRAPHDB_DATA_ENCRYPTION_FILE: {{ required "configuration.encryption.file is required" .Values.configuration.encryption.file }} | ||
| {{- if eq .Values.configuration.encryption.type "pkcs12" }} | ||
| GRAPHDB_DATA_ENCRYPTION_KEYSTORE_ALIAS: {{ required "configuration.encryption.alias is required ".Values.configuration.encryption.alias }} |
Contributor
There was a problem hiding this comment.
Suggested change
| GRAPHDB_DATA_ENCRYPTION_KEYSTORE_ALIAS: {{ required "configuration.encryption.alias is required ".Values.configuration.encryption.alias }} | |
| GRAPHDB_DATA_ENCRYPTION_KEYSTORE_ALIAS: {{ required "configuration.encryption.alias is required " .Values.configuration.encryption.alias }} |
| - name: graphdb-secret-properties | ||
| secret: | ||
| secretName: {{ include "graphdb.fullname.secret.properties" . }} | ||
| {{- if or (eq .Values.configuration.encryption.type "file" ) (eq .Values.configuration.encryption.type "pkcs12") }} |
Contributor
There was a problem hiding this comment.
Casn this be based on simply if .Values.configuration.encryption.type ?
| {{- with .Values.extraEnv }} | ||
| env: {{- tpl (toYaml .) $ | nindent 12 }} | ||
| {{- end }} | ||
| env: |
Contributor
There was a problem hiding this comment.
For a bit more clean render, wrap env with a check to avoid rendering it empty if no encr is configured
| initContainerResources: | ||
| limits: | ||
| memory: 16Mi | ||
| memory: 100Mi |
| @@ -0,0 +1,9 @@ | |||
| configuration: | |||
| externalUrl: http://127.0.0.1.nip.io/ | |||
Contributor
There was a problem hiding this comment.
externalUrl can be omited from the example.
| kubectl create secret generic graphdb-masterkeyfile --from-file=masterKey=master.key | ||
| helm install --values enc-file-values.yaml graphdb ontotext/graphdb | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
An extra empty line that can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.