GDB-14258 run and fix sparql view tests#2979
Draft
svilenvelikov wants to merge 1 commit into
Draft
Conversation
svilenvelikov
force-pushed
the
GDB-14258-run-and-fix-sparql-view-tests
branch
from
0df7da2 to
e214843
Compare
Make the new SPARQL view to be default Extend selector for no active repo message to account the new sparql view structure Fixing yasgui-tabs.spec Change sparql view test related with tabs to use a real query to prevent failings Changed the yasgui default http method to POST. The method is used when issuing a sparql query. The default in the yasgui component is also POST. Revert the stub in editor tabs test. The issue was the wrong http method used when executing the query which cause the interceptor to not be triggered. Removed the redundant spy on sparql endpoint because it is already intercepted in the beforeEach Fix error response message extraction for the error toastr Update save query tests to use a new page object for the onto-toastr component
svilenvelikov
force-pushed
the
GDB-14258-run-and-fix-sparql-view-tests
branch
from
e214843 to
2f1e78d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Make the new SPARQL view to be default
Extend selector for no active repo message to account the new sparql view structure
Fixing yasgui-tabs.spec
Change sparql view test related with tabs to use a real query to prevent failings
Changed the yasgui default http method to POST. The method is used when issuing a sparql query. The default in the yasgui component is also POST.
Revert the stub in editor tabs test. The issue was the wrong http method used when executing the query which cause the interceptor to not be triggered.
Removed the redundant spy on sparql endpoint because it is already intercepted in the beforeEach
Fix error response message extraction for the error toastr
Update save query tests to use a new page object for the onto-toastr component
Testing
Screenshots
Checklist