Cherry pick: GDB-14677 add target to loader component#2991
Draft
plamen-yordanov wants to merge 1 commit into
Draft
Cherry pick: GDB-14677 add target to loader component#2991plamen-yordanov wants to merge 1 commit into
plamen-yordanov wants to merge 1 commit into
Conversation
## What Add target selector to `onto-loader` component. ## Why To decouple the loader from the layout and simplify the layout altogether ## How - Introduced a new `targetSelector` property in `onto-loader` to specify the DOM element for attachment. - Attached the loader to the `main` element - Removed the main slot wrapper, the tooltip and the dialog from the layout to simplify them. - Updated styles ## Testing n/a (cherry picked from commit 0d10504)
|
Collaborator
|
This was prioritized for 11.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add target selector to
onto-loadercomponent.Why
To decouple the loader from the layout and simplify the layout altogether
How
targetSelectorproperty inonto-loaderto specify the DOM element for attachment.mainelementTesting
n/a
(cherry picked from commit 0d10504)
Checklist