GDB-12880 introduce repository picker list#2994
Open
svilenvelikov wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new “repository picker list” UI and surfaces it in the “repository required” banner, alongside styling/build changes to support the new layout.
Changes:
- Adds
RepositoryPickerListComponentUI (template + SCSS) and embeds it inRepositoryRequiredBannerComponent. - Adds i18n labels (EN/FR) for repository picker actions.
- Introduces Bootstrap SCSS imports and adjusts the Webpack/Sass loader configuration.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/workbench/src/styles.scss | Adds scoped Bootstrap SCSS imports under app-root. |
| packages/workbench/src/assets/i18n/en.json | Adds repository picker list button labels. |
| packages/workbench/src/assets/i18n/fr.json | Adds repository picker list button labels (FR). |
| packages/workbench/src/app/components/repository-required-banner/repository-required-banner.component.ts | Imports and wires in the repository picker list component. |
| packages/workbench/src/app/components/repository-required-banner/repository-required-banner.component.html | Renders the repository picker list under the info message. |
| packages/workbench/src/app/components/repository-picker-list/repository-picker-list.component.ts | Implements repository picker list state/actions (currently incomplete). |
| packages/workbench/src/app/components/repository-picker-list/repository-picker-list.component.html | Adds toolbar + repository list rendering. |
| packages/workbench/src/app/components/repository-picker-list/repository-picker-list.component.scss | Adds styling/layout for the repository picker list. |
| packages/workbench/package.json | Adds Bootstrap dependency. |
| packages/workbench/package-lock.json | Locks Bootstrap and peer deps. |
| packages/workbench/extra-webpack.config.js | Patches sass-loader options (silencing deprecations + load paths). |
| packages/workbench/angular.json | Adjusts custom webpack merge strategy. |
Files not reviewed (1)
- packages/workbench/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
svilenvelikov
force-pushed
the
GDB-12880-introduce-repository-picker-list-component
branch
9 times, most recently
from
22ad51a to
9024a48
Compare
svilenvelikov
force-pushed
the
GDB-12880-introduce-repository-picker-list-component
branch
3 times, most recently
from
48e0fef to
a54a407
Compare
Enhance repository picker list component with improved styling and layout Add responsive breakpoints and update media queries in styles Add remote location display and toggle functionality in repository picker list component Improve styling of the repository list component. Improved the primeng's link button styling by removing the underline from icons if any Removed the lead class from the alert components in the core-error directive. It enforces a larger font-size and weight which makes everything inside the component bigger and inconsistent. This was probably added by some mistake long time ago. Add a new stateLowercase property to Repository model. This can be used as a marker css class inside templates for example without transformation. Redesigned the repository list component to match the mockup Added filter fields Change icon and messag ein the no repository banner Add section with primeng message components in the ux-test page Add tooltip to the repo state icon Use css variables consistently Subscribe to repository list changes and update the local list Don't show actions if license is invalid Add a page-restrictions component that wraps all alert banners and the repository list picker Experiment with the restricted message resolving Resolver Implemented restriction resolver service and updated the page restrictions component to use it. Hide filters and the repo list from the view when there aren't repositories in the instance. Update the isrestricted default value parameter and add a TODO to fix some issue related with the isRepoManager method Update restriction resolver to allow multiple restrictions to be combined Moved the repository-picker-list out of the loop because we don't want multiple picker to be rendered and restricted it to be rendered only when there is no selected repository and there are available repositories Extracted a view model for the repository picker list component. Also changed visibility of some parts based on different conditions. Position the repo icon vertically in the middle Change row hover cursor to normal Fix the banner position Updated restrictions resolver and labels Add label that should not be checked for translation Fix failing test
svilenvelikov
force-pushed
the
GDB-12880-introduce-repository-picker-list-component
branch
from
a54a407 to
4a78a0a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduce repository picker list component.
Why
This is a component which is accessible on all pages that depend on having an active repository.
How
Implemented a repository picker list component that allows the user to select a repository, filter available local or remote repositories or quick access the repository create page.
Additionally:
Testing
Implemented tests.
Screenshots
Checklist