Conversation
|
@pgan002 Can you provide a link to a build, which is failing? Unlike the other test folder tests-with-llm lacks __init__.py file and hence is not a module. Do you think you should add such? |
|
A failing test is linked in the Jira ticket, but I added a link in the PR description. PR adding |
|
I mislead you, adding __init__.py doesn't solve the issue (but please keep it for consistency). Indeed we need to either export PYTHONPATH (as you did) or add in pyproject.toml |
Added in #75 as an alternative to this PR. When we merge one of these PRs, we will close the other. |
|
The tests pass on GitHub as well. Example https://github.com/Ontotext-AD/graphrag-eval/actions/runs/26634186922. Can we close this PR? |
What changed to make them pass? |
IMO they were passing before, check this one https://github.com/Ontotext-AD/graphrag-eval/actions/runs/25108289498 |
Fix imports in Github CI, which caused
tests-with-llm/*to start failing there (although they pass locally).The fix is to explicitly set environment variable
PYTHONPATH.This is needed due to a change in how
PYTONPATHis treated, either because of a change in project configuration or thepytestversion.An alternative solution is #75 .