You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found one substantive issue: DelayedVector.as_geodataframe() currently builds a GeoDataFrame from self.geometries only, so feature properties are dropped. As a result, to_save_result(DelayedVector(...), format="parquet") writes only the geometry column, while id and pop from FeatureCollection02.json are lost. That matches the TODO in tests/test_save_result_parquet.py where the delayed-vector path currently ends up with shape (2, 1) instead of preserving the attributes like the direct gpd.read_file(...) path does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while fixing typings with mypy
Related Open-EO/openeo-geopyspark-driver#793