Skip to content

Fix for DelayedVector that are not geojson format.#522

Open
EmileSonneveld wants to merge 4 commits into
masterfrom
to_save_result_fix
Open

Fix for DelayedVector that are not geojson format.#522
EmileSonneveld wants to merge 4 commits into
masterfrom
to_save_result_fix

Conversation

@EmileSonneveld

@EmileSonneveld EmileSonneveld commented Jun 29, 2026

Copy link
Copy Markdown
Member

Found while fixing typings with mypy
Related Open-EO/openeo-geopyspark-driver#793

@Open-EO Open-EO deleted a comment from chatgpt-codex-connector Bot Jun 29, 2026
@EmileSonneveld

Copy link
Copy Markdown
Member Author

@copilot review without making changes

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@copilot review without making changes

I found one substantive issue: DelayedVector.as_geodataframe() currently builds a GeoDataFrame from self.geometries only, so feature properties are dropped. As a result, to_save_result(DelayedVector(...), format="parquet") writes only the geometry column, while id and pop from FeatureCollection02.json are lost. That matches the TODO in tests/test_save_result_parquet.py where the delayed-vector path currently ends up with shape (2, 1) instead of preserving the attributes like the direct gpd.read_file(...) path does.

else:
data = data.to_driver_vector_cube()
elif isinstance(data, DriverDataCube):
if isinstance(data, DriverDataCube):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeroenVerstraelen I found this while checking with mypy. This makes sure the 'data' used in the object that is returned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants