fix: support raw JSON response tool arguments - #14
Merged
Conversation
Deploying new-api with
|
| Latest commit: |
e017332
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8b05ed46.new-api-d57.pages.dev |
| Branch Preview URL: | https://agent-fix-responses-object-a.new-api-d57.pages.dev |
lyz52789
marked this pull request as ready for review
July 12, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
argumentsas raw JSON instead of requiring a JSON stringresponse.output_item.done.item.argumentsandresponse.completed.response.output[].argumentsWhy
Some OpenAI-compatible upstreams return function-call arguments as a JSON object. The existing
stringDTO rejects those events during stream decoding with errors such as:This ports the focused upstream fix from QuantumNous/new-api commit
db89b57e1c8ce27dcd38273a4791f806da789a57and adds an end-to-end DTO regression test for both observed stream locations.Independence
This commit is based directly on the current
origin/maincommit738bbf25fdb42a46f891e3a80d4b18b6f9b275f3. It was tested from a clean detached worktree with no other local or upstream patches applied.Validation
All targeted packages pass from the clean worktree.