fix: allow cross-origin patch requests - #20
Merged
Conversation
Include PATCH in the CORS preflight response so browser clients can rename Seedance actors and assets across www.token123.co and api.token123.co. Add a regression test for the actor rename preflight.
Deploying new-api with
|
| Latest commit: |
0d4bb4a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76256044.new-api-d57.pages.dev |
| Branch Preview URL: | https://agent-fix-default-actor-rena.new-api-d57.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATCHrequests in the gateway CORS middlewarewww.token123.coandapi.token123.coRoot cause
The frontend uses
PATCHfor actor rename, but the API CORS middleware did not includePATCHinAccess-Control-Allow-Methods. Browsers stopped the request at the preflight stage, before the actor controller or database update ran.Test plan
go test ./middleware -count=1go test ./... -count=1