fix: use CORS-compatible Seedance updates - #21
Merged
Conversation
Route Seedance actor and asset updates through PUT so browser clients remain compatible with the production edge CORS policy. Keep PATCH aliases for existing API consumers and cover the new authenticated routes.
Deploying new-api with
|
| Latest commit: |
39a41f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c08d98d.new-api-d57.pages.dev |
| Branch Preview URL: | https://agent-fix-seedance-put.new-api-d57.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUTfor Seedance actor and asset updates from the browserPUTaliases on the backend while retainingPATCHcompatibility for existing API clientsWhy
The production edge currently advertises
GET, POST, PUT, DELETE, OPTIONSfor CORS preflight requests. Even after the application addedPATCH, the edge response continued to omit it. Browsers therefore blocked actor rename before it reached the API.PUTis appropriate for these idempotent name updates and works with the deployed edge policy.Test plan
go test ./... -count=1bunx prettier src/services/seedanceAssets.js --checkbun run buildPUTpreflight and unauthenticated route smoke tests after deployment