Skip to content

[php-nextgen] Remove request body handling if no request body exists#23995

Merged
wing328 merged 11 commits into
OpenAPITools:masterfrom
coffeemakr:nextgen-php-remove-request-body-handling
Jun 11, 2026
Merged

[php-nextgen] Remove request body handling if no request body exists#23995
wing328 merged 11 commits into
OpenAPITools:masterfrom
coffeemakr:nextgen-php-remove-request-body-handling

Conversation

@coffeemakr

@coffeemakr coffeemakr commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
  • Remove request processing if there is no body (unused code)
  • Change imports of FormProcessor and MultipartStream so no unused imports exist

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Remove request body/form handling and related variables/imports from generated php-nextgen APIs when operations have no body. This cleans up dead code and avoids unused imports in generated clients.

  • Refactors
    • Update api.mustache to emit body/form blocks only when needed; remove unused FormDataProcessor import and inline MultipartStream usage.
    • Regenerate PHP samples to drop empty $formParams, $queryParams, and body-processing code where not applicable.
    • Add test and fixture to ensure no form/body blocks are generated without body/form params.

Written for commit c8962bd. Summary will update on new commits.

Review in cubic

@coffeemakr coffeemakr changed the title [php-nextgen] Remove request body handling if no request body is used [php-nextgen] Remove request body handling if no request body exists Jun 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 22 files

Re-trigger cubic

@wing328 wing328 merged commit 719aaed into OpenAPITools:master Jun 11, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants