fix(feishu): preserve encryptKey and verifyToken on config save#377
Open
Gucc111 wants to merge 1 commit into
Open
fix(feishu): preserve encryptKey and verifyToken on config save#377Gucc111 wants to merge 1 commit into
Gucc111 wants to merge 1 commit into
Conversation
The /feishu/save and /feishu/qr-poll routes replaced the entire feishu config object, dropping fields like encryptKey and verifyToken that the runtime reads for callback decryption and verification. Spread the previous config before applying new values so that unmanaged fields survive a save, matching the wecom save pattern. Closes OpenBMB#227 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/feishu/saveand/feishu/qr-pollroutes to preserve existing config fields (e.g.encryptKey,verifyToken) when saving Feishu settings, instead of replacing the entire config object.writeWeComConfig.Closes #227
Test plan
encryptKeyandverifyTokeninpilotdeck.yaml, then save Feishu settings from the UI — verify both fields survive.appId,appSecret,connectionMode,domainName) are updated correctly.Made with Cursor