Skip to content

fix(keymap): unblock ~46 integration tests by retiring ctrl-b binding on linux/windows #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
May 31, 2026
+7 −1
Merged

fix(keymap): unblock ~46 integration tests by retiring ctrl-b binding on linux/windows #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/workspace/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,13 @@ pub fn init(app: &mut AppContext) {
.with_context_predicate(id!("Workspace"))
.with_custom_action(CustomAction::ToggleWarpDrive)
.with_mac_key_binding("cmd-b")
.with_linux_or_windows_key_binding("ctrl-b"),
// `ctrl-b` is the ASCII STX control character — registering it on
// Linux/Windows trips `is_binding_pty_compliant` on the Workspace
// view and panics binding validation at boot. Use `ctrl-shift-B`,
// matching the convention `cmd_or_ctrl_shift` documents for
// single-letter Mac shortcuts that would otherwise collide with the
// PTY on non-Mac platforms.
.with_linux_or_windows_key_binding("ctrl-shift-B"),
EditableBinding::new(
TOGGLE_RIGHT_PANEL_BINDING_NAME,
BindingDescription::new("Toggle code review")
Expand Down
Loading