Skip to content

Fix/GitHub#367

Closed
RM-Imane-2026 wants to merge 2 commits into
OpenCoworkAI:mainfrom
J35u5128:fix/github
Closed

Fix/GitHub#367
RM-Imane-2026 wants to merge 2 commits into
OpenCoworkAI:mainfrom
J35u5128:fix/github

Conversation

@RM-Imane-2026
Copy link
Copy Markdown

Summary

Type of change

  • Bug fix
  • New feature
  • Refactor (no behavior change)
  • Documentation
  • Build / CI / tooling
  • Breaking change

Linked issue

Checklist

  • I checked the linked issue / relevant context before starting
  • pnpm lint && pnpm typecheck && pnpm test passes locally
  • Added/updated tests for the change
  • Added a changeset (pnpm changeset) if user-visible
  • Updated docs if behavior changed

Dependency additions (if any)

Screenshots / recordings (UI changes)

@github-actions github-actions Bot added the area:build Turbo/Vite/Biome/tsconfig toolchain label May 25, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review mode: initial

Findings

  • [Blocker] New CI workflow uses npm and Node 18, incompatible with the project stack
    .github/workflows/test.yml:20,24,28,43 — The workflow runs npm ci and sets node-version: '18'. This project requires node >=22 and uses pnpm (see package.json engines and packageManager fields). npm ci will fail because only pnpm-lock.yaml is present, not package-lock.json. The scripts test:unit and test:e2e do not exist in package.json; the correct commands are pnpm test (or turbo run test).

    Suggested fix: Replace this workflow entirely. The project already has a CI pipeline; if a new workflow is needed, it must use pnpm, Node 22, and correct script names. Otherwise delete the file.

  • [Blocker] Pre-commit and pre-push hooks are disabled, removing all automated checks
    .husky/pre-commit — Previously ran pnpm lint; now only contains a shebang and commented-out commands. .husky/pre-push — Previously ran pnpm -r typecheck, pnpm lint, pnpm test; now replaced with a Spanish comment saying “Hook temporarily disabled to allow push”. This removes lint, typecheck, and test validation on every commit/push, which is a maintainability and regression risk. No justification or tracking issue is provided.

    Suggested fix: Revert both hooks to their original content. If a temporary disable is genuinely needed, open an issue to track re-enablement and reference it in the commit.

  • [Minor] Missing changeset for a user-visible CI/build change
    This PR modifies contributor workflow (hooks, CI). Per project convention, user-visible changes should include a changeset (pnpm changeset). The PR checklist also has “Added a changeset” unchecked.

    Suggested fix: Run pnpm changeset with a description of the CI and hook changes, or explain why no changeset is needed.

Summary

This PR introduces a broken CI workflow that is incompatible with the project’s package manager and Node version, and disables all pre-commit and pre-push validation without context. Neither change is safe to merge. I recommend closing this PR and, if changes to CI or hooks are needed, opening a new one with correct implementations and a linked issue.

Questions

  • Is there an existing issue or reason for disabling the husky hooks? If yes, please link it; otherwise they should be restored immediately.

Open-CoDesign Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Turbo/Vite/Biome/tsconfig toolchain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant