Fix/GitHub#367
Conversation
There was a problem hiding this comment.
Review mode: initial
Findings
-
[Blocker] New CI workflow uses
npmand Node 18, incompatible with the project stack
.github/workflows/test.yml:20,24,28,43— The workflow runsnpm ciand setsnode-version: '18'. This project requiresnode >=22and usespnpm(seepackage.jsonenginesandpackageManagerfields).npm ciwill fail because onlypnpm-lock.yamlis present, notpackage-lock.json. The scriptstest:unitandtest:e2edo not exist inpackage.json; the correct commands arepnpm test(orturbo run test).Suggested fix: Replace this workflow entirely. The project already has a CI pipeline; if a new workflow is needed, it must use
pnpm, Node 22, and correct script names. Otherwise delete the file. -
[Blocker] Pre-commit and pre-push hooks are disabled, removing all automated checks
.husky/pre-commit— Previously ranpnpm lint; now only contains a shebang and commented-out commands..husky/pre-push— Previously ranpnpm -r typecheck,pnpm lint,pnpm test; now replaced with a Spanish comment saying “Hook temporarily disabled to allow push”. This removes lint, typecheck, and test validation on every commit/push, which is a maintainability and regression risk. No justification or tracking issue is provided.Suggested fix: Revert both hooks to their original content. If a temporary disable is genuinely needed, open an issue to track re-enablement and reference it in the commit.
-
[Minor] Missing changeset for a user-visible CI/build change
This PR modifies contributor workflow (hooks, CI). Per project convention, user-visible changes should include a changeset (pnpm changeset). The PR checklist also has “Added a changeset” unchecked.Suggested fix: Run
pnpm changesetwith a description of the CI and hook changes, or explain why no changeset is needed.
Summary
This PR introduces a broken CI workflow that is incompatible with the project’s package manager and Node version, and disables all pre-commit and pre-push validation without context. Neither change is safe to merge. I recommend closing this PR and, if changes to CI or hooks are needed, opening a new one with correct implementations and a linked issue.
Questions
- Is there an existing issue or reason for disabling the husky hooks? If yes, please link it; otherwise they should be restored immediately.
Open-CoDesign Bot
Summary
Type of change
Linked issue
Checklist
pnpm lint && pnpm typecheck && pnpm testpasses locallypnpm changeset) if user-visibleDependency additions (if any)
Screenshots / recordings (UI changes)