Pin git dependencies to release tags for v0.1.0#858
Merged
Conversation
Pin all git dependencies to specific release tags or revisions to ensure reproducible builds: - embassy-imxrt: pin to v0.1.0 tag - embedded-cfu-protocol: pin to v0.1.0 tag - embedded-usb-pd: pin to v0.1.0 tag - tps6699x: pin to v0.1.0 tag - mctp-rs: move to OpenDevicePartnership fork, pin to v0.1.0 tag - keyberon: pin to specific commit revision Update rt633 espi_battery example to add strict_mode field required by the new embassy-imxrt I2C config. Update all Cargo.lock files to reflect the dependency changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make builds more reproducible for the v0.1.0 release by pinning git-based dependencies to release tags (or a specific revision), updating example configuration to match upstream API changes, and refreshing lockfiles across the repo and example workspaces.
Changes:
- Pin multiple git dependencies (embassy-imxrt, embedded-cfu-protocol, embedded-usb-pd, tps6699x, mctp-rs) to
v0.1.0tags and keyberon to a fixed commit revision. - Update the rt633
espi_batteryexample for the newembassy-imxrtI2C config (strict_mode). - Update Cargo.lock files to reflect the new dependency sources/versions.
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Pins workspace git dependencies to v0.1.0 tags and moves mctp-rs to the OpenDevicePartnership fork. |
Cargo.lock |
Updates resolved git sources/commits (and other transitive changes) to match the new pins. |
keyboard-service/Cargo.toml |
Pins keyberon to a specific git revision. |
examples/std/Cargo.toml |
Pins example git dependencies (embedded-usb-pd, embedded-cfu-protocol) to v0.1.0. |
examples/std/Cargo.lock |
Refreshes the std example’s resolved dependency graph. |
examples/rt685s-evk/Cargo.toml |
Pins embedded git dependencies for the rt685s-evk example to v0.1.0. |
examples/rt685s-evk/Cargo.lock |
Refreshes the rt685s-evk example’s resolved dependency graph. |
examples/rt633/Cargo.toml |
Pins embassy-imxrt for the rt633 example to v0.1.0. |
examples/rt633/Cargo.lock |
Refreshes the rt633 example’s resolved dependency graph. |
examples/rt633/src/bin/espi_battery.rs |
Adds the required strict_mode field to the I2C master config. |
Adapt the test utility's MctpMedium implementation to match the updated mctp-rs trait which now requires: - An Encoding associated type (PassthroughEncoding for tests) - deserialize returning EncodingDecoder instead of raw &[u8] - serialize closure taking &mut EncodingEncoder instead of &mut [u8] Assisted-by: GitHub Copilot:claude-opus-4.6
RobertZ2011
approved these changes
May 21, 2026
williampMSFT
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies to use fixed versions or tags, improving build reproducibility and stability across the project. Additionally, it refactors the MCTP protocol test utilities to use encoding types for greater flexibility and type safety. There is also a minor configuration change to enable strict mode in I2C master configuration.
Dependency version pinning and updates:
Cargo.tomlfiles to use specific tags (e.g.,tag = "v0.1.0") or commit hashes instead of tracking the latest code on the main branch. This applies toembassy-imxrt,embedded-cfu-protocol,embedded-usb-pd,mctp-rs, andtps6699xacross several project and example manifests, as well askeyberoninkeyboard-service/Cargo.toml[1] [2] [3] [4] [5] [6] [7].MCTP protocol test refactor:
embedded-service/src/ec_type/protocols/mctp.rsto useEncodingDecoder,EncodingEncoder, andPassthroughEncodingtypes, improving type safety and future extensibility for encoded payloads [1] [2] [3] [4] [5].Configuration improvements:
strict_modein the I2C master configuration inexamples/rt633/src/bin/espi_battery.rsfor stricter protocol compliance.