Bump embedded-services, EC_TEST_CLI_REV, and embassy-time pins#19
Conversation
Update the embedded-services lockfile pins across all platforms to pick up the v0.2.0 branch HEAD (f1f1e087), which includes: - PR #852: uart-service Service<R, M> generic over MctpMedium - PR #854: v0.2.0 mergeback (heapless 0.9.2, embassy-time 0.5.1) Migrate all platforms from the removed Service::new(relay) API to DefaultService::default_smbusespi(relay), which preserves the SmbusEspi wire format used by existing hardware platforms. Bump EC_TEST_CLI_REV from e674ca93 to d705cd4f to pick up odp-platform-common PR #92, which adds SMBus PEC byte support to ec-test-cli's serial transport — required by the post-#852 SmbusEspiMedium. Bump dev-npcx embassy-time pins from 0.5.0 to 0.5.1 and embassy-time-driver from 0.2.1 to 0.2.2, matching the transitive requirements from the updated embedded-services. Assisted-by: GitHub Copilot CLI:claude-opus-4.6-1m-internal
Cargo Vet Audit Passed
|
|
1. What crates (with version) need to be audited? 18 crates total (union across all 4 platforms):
2. How many of the crates are version updates vs new dependencies?
3. To confirm none of the already included crates serve your needs, please provide a brief description of the purpose of the new crates.
4. Any extra notes to the auditors to help with their audits. All 18 unvetted crates are the result of |
Add safe-to-deploy exemptions for crate versions pulled in by the embedded-services v0.2.0 pin advancement. All are minor/patch version bumps of existing dependencies, except hashbrown 0.17.1 (new transitive from heapless 0.9). Assisted-by: GitHub Copilot CLI:claude-opus-4.6-1m-internal
There was a problem hiding this comment.
Pull request overview
This PR performs an atomic dependency/pin bump across the embedded controller platforms so the firmware’s UART/SMBus-eSPI transport and the ec-test-cli host tooling stay in sync after upstream changes (notably SMBus PEC handling and uart-service API updates).
Changes:
- Bump
embedded-services(v0.2.0 branch HEAD) and refresh per-platform lockfiles/supply-chain exemptions accordingly. - Update platform UART service initialization to use
uart_service::DefaultService::default_smbusespi(...)(new upstream API/medium behavior). - Bump
EC_TEST_CLI_REVin CI and updatedev-npcxEmbassy time crate pins to match updated transitive requirements.
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/check.yml |
Updates the pinned ec-test-cli revision used by the integration-test job. |
platform/dev-imxrt/src/main.rs |
Migrates UART service setup to the new uart-service default SMBus/eSPI service constructor. |
platform/dev-imxrt/Cargo.lock |
Updates locked dependency SHAs/versions to the new embedded-services commit and related transitive updates. |
platform/dev-imxrt/supply-chain/config.toml |
Adds cargo-vet exemptions for newly introduced crate versions from the lockfile refresh. |
platform/dev-mcxa/src/main.rs |
Migrates UART service setup to the new uart-service default SMBus/eSPI service constructor. |
platform/dev-mcxa/Cargo.lock |
Updates locked dependency SHAs/versions to the new embedded-services commit and related transitive updates. |
platform/dev-mcxa/supply-chain/config.toml |
Adds cargo-vet exemptions for newly introduced crate versions from the lockfile refresh. |
platform/dev-npcx/src/main.rs |
Migrates UART service setup to the new uart-service default SMBus/eSPI service constructor. |
platform/dev-npcx/Cargo.toml |
Bumps embassy-time / embassy-time-driver versions and patch pins. |
platform/dev-npcx/Cargo.lock |
Updates locked dependency SHAs/versions to the new embedded-services commit and related transitive updates. |
platform/dev-npcx/supply-chain/config.toml |
Adds cargo-vet exemptions for newly introduced crate versions (and Embassy rev-related entries). |
platform/dev-qemu/src/main.rs |
Migrates UART service setup to the new uart-service default SMBus/eSPI service constructor. |
platform/dev-qemu/Cargo.lock |
Updates locked dependency SHAs/versions to the new embedded-services commit and related transitive updates. |
platform/dev-qemu/supply-chain/config.toml |
Adds cargo-vet exemptions for newly introduced crate versions from the lockfile refresh. |
Replace the rev-pinned policy key for embassy-sync with a generic [policy.embassy-sync] entry (matching dev-imxrt's approach), and add an exemption for the new git rev. The old rev (c8715fc1) no longer matches the lockfile (e9c32931) after the embedded-services bump. Assisted-by: GitHub Copilot CLI:claude-opus-4.6-1m-internal
jerrysxie
left a comment
There was a problem hiding this comment.
We added a lot of exemption for cargo vet. Okay for now, we will audit the exemption later as an ODP wide exemption audit.
Summary
Atomic pin bump to pick up two coordinated upstream changes:
f1f1e087(includes PR Make uart-service::Service generic over MctpMedium; delete fake-PEC strips embedded-services#852:uart-service::Service<R, M>generic overMctpMedium, spec-compliantSmbusEspiMediumwith PEC)d705cd4f(includes PR Add SMBus PEC byte to ec-test-lib serial transport odp-platform-common#92:ec-test-cliserial transport now emits + verifies SMBus PEC byte)These two changes MUST land together — if only one pin is bumped, the
integration-test:CI job fails because the EC and host disagree on whether the SMBus PEC byte is present.Changes
.github/workflows/check.yml:EC_TEST_CLI_REV: e674ca93→d705cd4fplatform/{dev-imxrt,dev-mcxa,dev-npcx,dev-qemu}/src/main.rs: migrateuart_service::Service::new(relay)→uart_service::DefaultService::default_smbusespi(relay)(required by PR #852's API change fromService<R>toService<R, M>)platform/{dev-imxrt,dev-mcxa,dev-qemu}/Cargo.lock:cargo updateto pick up new embedded-services SHAplatform/dev-npcx/Cargo.toml: bumpembassy-time0.5.0 → 0.5.1,embassy-time-driver0.2.1 → 0.2.2 (required by transitive deps from the updated embedded-services v0.2.0 mergeback)platform/dev-npcx/Cargo.lock: updated accordinglyValidation
All 4 platforms (
dev-imxrt,dev-mcxa,dev-npcx,dev-qemu) passcargo checklocally.