Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeaState: On-demand block partitioning of wave kinematics to reduce memory (WvKinBlockMod) #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
SeaState: On-demand block partitioning of wave kinematics to reduce memory (WvKinBlockMod) #3388
Changes from all commits
28fbefd0160d297ed86834995727b06786996dd1dba008956b4bea277b0e829068b367f20bf2a78ca8a669eaa3d11384dc8ffae3a97decaeb5a3039File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is WvKinBlockMod made a switch? Are you expecting additional options in the future? If not, this could be a TRUE/FALSE flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mode 1 is referring to
WvKinBlockMod=1, but you are right, I should just change that to a TRUE/FALSE flagUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.