feat: update usage of getActiveProject to getCheckedOutProject#1360
Merged
josephjclark merged 10 commits intorelease/nextfrom Apr 10, 2026
Merged
feat: update usage of getActiveProject to getCheckedOutProject#1360josephjclark merged 10 commits intorelease/nextfrom
josephjclark merged 10 commits intorelease/nextfrom
Conversation
josephjclark
reviewed
Apr 8, 2026
Collaborator
Author
|
@josephjclark this is green now. I'll be setting the base of #1358 to this to make sure that PR works from this branch. |
Collaborator
|
Looks good @doc-han . Will you be doing any work on those tests or is this ready to merge? |
Collaborator
Author
I'm updating the tests. then it's ready to merge |
josephjclark
reviewed
Apr 9, 2026
josephjclark
approved these changes
Apr 10, 2026
josephjclark
added a commit
that referenced
this pull request
Apr 10, 2026
* update the worker to node 24 (#1357) * update the worker to node 24 * update docker docs * changeset * Worker: fix an issue with batch logging (#1353) * set min-release-age * versions * debugging flaky test * fix an issue where the batch is never clear * fix a timing issue when sending batch events Big help from claude * logging * add a bunch of more controlled unit tests * test on interrupt * update and fix tests I think this this fixes the actual issue - I just want more good focused tests now * tidy logging * more tests * changeset * types * remove only * run tests in serial * worker: tweak event processor and be sure to reset timeout on batch * remove comment * remove more comments * feat: update usage of getActiveProject to getCheckedOutProject (#1360) * feat: update getActiveProject to getCheckedOutProject * feat: back to active project * chore: rename getActiveProject to getTrackedProject * feat: deploy should use getTrackedProject * chore: getCheckedout return undefined like getActiveprojects * fix: types * feat: update removed & renamed workflows on checkout (#1358) * tests: remove unwanted fields * feat: use currentProject * tests: remove fields * versions --------- Co-authored-by: Farhan Y. <yahyafarhan48@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
We've had some wrong usages of
getActiveProjectwheregetCheckedoutProjectwas supposed to be used.This pR reviews all usages and makes the needed change. one picks from the last pull state and the other picks project from disk(actually checked out project)
Fixes #1359
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.