Skip to content

fix(project): include trigger reply fields in version hash #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(project): include trigger reply fields in version hash #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/quiet-seals-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@openfn/project': patch
'@openfn/cli': patch
---

Include `webhook_reply` and `cron_cursor_job_id` in workflow version hashes.
8 changes: 7 additions & 1 deletion packages/project/src/util/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,13 @@ export const generateHash = (
'body',
].sort();

const triggerKeys = ['type', 'cron_expression', 'enabled'].sort();
const triggerKeys = [
'type',
'cron_expression',
'enabled',
'webhook_reply',
'cron_cursor_job_id',
].sort();

const edgeKeys = [
'name', // generated
Expand Down
34 changes: 34 additions & 0 deletions packages/project/test/util/version-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,40 @@ test('hash a trigger', (t) => {
t.not(generateHash(webhook), generateHash(cronExpression));
});

test('hash changes when webhook_reply changes', (t) => {
const wf1 = generateWorkflow(
`@name wf-1
@id workflow-id
t(type=webhook,webhook_reply=x)-x
`
);
const wf2 = generateWorkflow(
`@name wf-1
@id workflow-id
t(type=webhook,webhook_reply=y)-x
`
);

t.not(generateHash(wf1), generateHash(wf2));
});

test('hash changes when cron_cursor_job_id changes', (t) => {
const wf1 = generateWorkflow(
`@name wf-1
@id workflow-id
t(type=cron,cron_expression="1",cron_cursor_job_id=x)-x
`
);
const wf2 = generateWorkflow(
`@name wf-1
@id workflow-id
t(type=cron,cron_expression="1",cron_cursor_job_id=y)-x
`
);

t.not(generateHash(wf1), generateHash(wf2));
});

test('hash changes across an edge', (t) => {
const basicEdge = generateWorkflow(
`
Expand Down