fix: update return types and simplify conditions

Author: Morgy93

src/Console/Command/System/CheckCommand.php

@@ -238,7 +238,7 @@ private function getMysqlVersionViaPdo(): ?string
     /**
      * Get database configuration from environment variables
      *
-     * @return array
+     * @return array<string, string>
      */
     private function getDatabaseConfig(): array
     {
@@ -500,7 +500,7 @@ private function checkSearchEngineConnections(): ?string
     /**
      * Get potential search engine hosts
      *
-     * @return array
+     * @return string[]
      */
     private function getSearchEngineHosts(): array
     {
@@ -531,7 +531,7 @@ private function getSearchEngineHosts(): array
     /**
      * Format search engine version output
      *
-     * @param array $info
+     * @param array<string, mixed> $info
      * @return string
      */
     private function formatSearchEngineVersion(array $info): string
@@ -549,7 +549,7 @@ private function formatSearchEngineVersion(array $info): string
      * Test Elasticsearch connection and return version info
      *
      * @param string $url
-     * @return array|bool
+     * @return array<string, mixed>|false
      */
     private function testElasticsearchConnection(string $url)
     {
@@ -573,7 +573,7 @@ private function testElasticsearchConnection(string $url)
      * Try to connect using Magento's HTTP client
      *
      * @param string $url
-     * @return array|null
+     * @return array<string, mixed>|null
      */
     private function tryMagentoHttpClient(string $url): ?array
     {
@@ -603,7 +603,7 @@ private function tryMagentoHttpClient(string $url): ?array
     /**
      * Get important PHP extensions
      *
-     * @return array
+     * @return array<int, array<int, string>>
      */
     private function getImportantPhpExtensions(): array
     {
@@ -757,8 +757,8 @@ private function getSystemEnvironmentValue(string $name): ?string
     {
         // Use ini_get for certain system variables as a safer alternative
         if (in_array($name, ['memory_limit', 'max_execution_time'])) {
-            $value = ini_get($name);
-            if ($value !== false) {
+            $value = (string)ini_get($name);
+            if ($value !== '') {
                 return $value;
             }
         }

src/Console/Command/Theme/BuildCommand.php

@@ -492,7 +492,7 @@ private function getServerVar(string $name): ?string
     private function setEnvVar(string $name, string $value): void
     {
         // Validate input parameters
-        if (empty($name) || !is_string($name)) {
+        if (empty($name) ) {
             return;
         }
 

src/Console/Command/Theme/CleanCommand.php

@@ -638,7 +638,7 @@ private function getServerVar(string $name): ?string
      */
     private function setEnvVar(string $name, string $value): void
     {
-        if (empty($name) || !is_string($name)) {
+        if (empty($name) ) {
             return;
         }
 

src/Model/TemplateEngine/Decorator/InspectorHints.php

@@ -188,7 +188,7 @@ private function getParentBlockName(BlockInterface $block): string
     {
         if ($block instanceof AbstractBlock) {
             $parent = $block->getParentBlock();
-            if ($parent && method_exists($parent, 'getNameInLayout')) {
+            if ($parent instanceof AbstractBlock) {
                 return $parent->getNameInLayout() ?: '';
             }
         }
@@ -204,7 +204,7 @@ private function getParentBlockName(BlockInterface $block): string
      */
     private function getBlockAlias(BlockInterface $block): string
     {
-        if ($block instanceof AbstractBlock && method_exists($block, 'getNameInLayout')) {
+        if ($block instanceof AbstractBlock) {
             return $block->getNameInLayout() ?: '';
         }
 

src/Model/TemplateEngine/Plugin/InspectorHints.php

@@ -59,7 +59,7 @@ public function __construct(
      * @param TemplateEngineFactory $subject
      * @param TemplateEngineInterface $invocationResult
      * @return TemplateEngineInterface
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
      */
     public function afterCreate(
         TemplateEngineFactory $subject,