Skip to content

Fix Serial LED Manager to support less then 3 serial LEDs #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traxanos merged 2 commits into from
Jan 17, 2026
Merged

Fix Serial LED Manager to support less then 3 serial LEDs #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f01b0
Fix Serial LED Manager to support less then 3 serial LEDs
mgeramb Jan 16, 2026
1c419aa
codeformatter + use %u instead of %d
traxanos Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/OpenKNX/Led/Serial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ namespace OpenKNX

void SerialLedManager::init(uint8_t ledCount)
{
logInfo("SerialLedManager", "init");
logInfo("SerialLedManager", "init %u serial leds", ledCount);

// LED-Todo: check max led count based on platform

Expand All @@ -182,8 +182,8 @@ namespace OpenKNX
.gpio_num = (gpio_num_t)_ledPin,
.clk_src = RMT_CLK_SRC_DEFAULT, // select source clock
.resolution_hz = RMT_LED_STRIP_RESOLUTION_HZ,
.mem_block_symbols = (size_t)(ledCount * BITS_PER_LED_CMD), // increase the block size can make the LED less flickering
.trans_queue_depth = 1, // set the number of transactions that can be pending in the background
.mem_block_symbols = (size_t)max(64 /* required minimum */, ledCount * BITS_PER_LED_CMD), // increase the block size can make the LED less flickering
.trans_queue_depth = 1, // set the number of transactions that can be pending in the background
};
rmt_new_tx_channel(&tx_chan_config, &_led_chan);
_simple_encoder = NULL;
Expand Down
Loading