You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nach einem Test muss ich feststellen, folgendes funktioniert nicht: var apduLength = 15; if (typeof online.getMaxApduLength == "function") { apduLength = online.getMaxApduLength(); }
ETS-Log: 2026-04-21 13:31:23,683 [219] INFO Knx.Ets.Hawk.NetworkFacade - MaxCommunicationApduLength(13.0.36)=239 ... 2026-04-21 13:31:23,687 [226] INFO Script - BASE_invokeFunctionPropertyWrapper: APDU = 15
Ich werde die Änderung zurücknehmen.
Cornelius meinte wohl, dass eine Exception schlechter ist als ein if.
Das Problem war aber, dass er das nicht vorher getestet hatte. Und bin davon ausgegangen, dass es getestet ist und hatte natürlich nichts gegen die Vermeidung von Exceptions. Und da es ein PR war, hab ich gleich gemerged.
Mit dem try-catch würden mögliche andere Fehler verdeckt. Wobei wir hier trotzdem noch ein Fallback vorsehen sollten, damit es niemals daran scheitert.
Die Variable sollte (lokal in der Funktion) mit var deklariert werden.
Habe hier leider versäumt das Draft-Flag zu setzen und den Status hier im Ticket klarer zu dokumentieren. Mein Fehler :-\
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.