Skip to content

Fix: Sun-Calculations Day#140

Draft
cornelius-koepp wants to merge 2 commits into
v1devfrom
fix/sunrise-nz-rework
Draft

Fix: Sun-Calculations Day#140
cornelius-koepp wants to merge 2 commits into
v1devfrom
fix/sunrise-nz-rework

Conversation

@cornelius-koepp
Copy link
Copy Markdown
Member

Weitere Korrekturen für Sonnen-Berechnung im Zusammenhang mit Zeit-Basis.

Status: Ungetesteter Entwurf, zur Prüfung und Diskussion.

* Use local time based day for calculation of sun-rise and sun-set
  Note: resulting day-share can bet negative and is UTC
* Recalculation depending not only on hour and minute. Split calculation:
  * day-change => sun-rise/set
  * minute-change => sun position
* Provide DateTime instead of Time only for sun-rise and sun-set
Reorder calculations, but both are independend
@cornelius-koepp cornelius-koepp added this to the v1.8.1 milestone May 9, 2026
@cornelius-koepp cornelius-koepp linked an issue May 9, 2026 that may be closed by this pull request
5 tasks
@cornelius-koepp cornelius-koepp requested review from mgeramb and mumpf May 9, 2026 18:21
@cornelius-koepp cornelius-koepp added the bug Something isn't working label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SunRise-Calculation Differs from LogicModule

1 participant